8000 Fix flake8 issues by omgjlk · Pull Request #744 · sigmavirus24/github3.py · GitHub
[go: up one dir, main page]
Skip to content

Fix flake8 issues #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 15, 2017
Merged

Fix flake8 issues #744

merged 1 commit into from
Dec 15, 2017

Conversation

omgjlk
Copy link
Collaborator
@omgjlk omgjlk commented Dec 14, 2017

Ran into these in an unrelated PR.

Signed-off-by: Jesse Keating jkeating@j2solutions.net

@omgjlk
Fix flake8 issues
0a2010c 
Ran into these in an unrelated PR.

Don't have a bare except

Don't use single char variables

Also cap pytest at below 3.3.0, which drops support for py33 (we could
drop py33 support as well)

Signed-off-by: Jesse Keating <jkeating@j2solutions.net>
@omgjlk omgjlk mentioned this pull request Dec 14, 2017
Merged
@sigmavirus24 sigmavirus24 merged commit 6dcfd1d into sigmavirus24:develop Dec 15, 2017
@sigmavirus24
Copy link
Owner

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omgjlk @sigmavirus24
0