8000 Drop preview header from reviews API call by omgjlk · Pull Request #714 · sigmavirus24/github3.py · GitHub
[go: up one dir, main page]

Skip to content

Drop preview header from reviews API call #714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 15, 2017

Conversation

omgjlk
Copy link
Collaborator
@omgjlk omgjlk commented Jun 22, 2017

As of
https://developer.github.com/changes/2017-05-09-end-black-cat-preview/
the reviews endpoint is no longer preview, and is now an official part
of the API. It is no longer necessary to set a header when accessing
this endpoint.

@omgjlk omgjlk force-pushed the official-pr-review-api branch 2 times, most recently from f957edf to d3aaa4a Compare December 13, 2017 20:36
@sigmavirus24
Copy link
Owner

Closing & re-opening to trigger a re-test.

@sigmavirus24 sigmavirus24 reopened this Dec 15, 2017
@omgjlk omgjlk force-pushed the official-pr-review-api branch from d3aaa4a to a628406 Compare December 15, 2017 04:33
As of
https://developer.github.com/changes/2017-05-09-end-black-cat-preview/
the reviews endpoint is no longer preview, and is now an official part
of the API. It is no longer necessary to set a header when accessing
this endpoint.

Signed-off-by: Jesse Keating <jkeating@j2solutions.net>
@omgjlk omgjlk force-pushed the official-pr-review-api branch from a628406 to efd164b Compare December 15, 2017 05:31
@sigmavirus24 sigmavirus24 merged commit 856ec18 into sigmavirus24:develop Dec 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0