8000 Update AUTHORS.rst by beccasjames · Pull Request #692 · sigmavirus24/github3.py · GitHub
[go: up one dir, main page]
Skip to content

Update AUTHORS.rst #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 20, 2017
Merged

Update AUTHORS.rst #692

merged 1 commit into from
Dec 20, 2017

Conversation

beccasjames
Copy link
Contributor

Adding name to contributors list per contributor guidelines

@omgjlk
Copy link
Collaborator
omgjlk commented Dec 13, 2017

Hi Becca! I did a quick git log of the develop branch and I couldn't find a contribution from you. I think this change here should be bundled with #691 as that would be the PR that would bring your contributions into the project.

I can help guide you through adding the commit to that PR, if you'd like. I'm not making any assumptions, just offering help.

@beccasjames @omgjlk
Update AUTHORS.rst
f2fd804 
Adding name to contributors list per contributor guidelines
@omgjlk
Copy link
Collaborator
omgjlk commented Dec 19, 2017

I rebased this to resolve the conflict.

omgjlk
omgjlk approved these changes Dec 19, 2017
View reviewed changes
Copy link
Collaborator
@omgjlk omgjlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that the other PR has merged, this can be merged too!

@omgjlk omgjlk merged commit 212ef93 into sigmavirus24:develop Dec 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omgjlk omgjlk omgjlk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@beccasjames @omgjlk
0