Excise NullObject from github3.py #678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of on going work to improve the overall design and simplicity, we're removing the NullObject and it's usage. At the present time, it causes a lot of confusion for users (not as much as Empty, but still up there) and there are simpler ways of designing the library than this. Related-to #670
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of on going work to improve the overall design and simplicity,
we're removing the NullObject and it's usage. At the present time, it
causes a lot of confusion for users (not as much as Empty, but still up
there) and there are simpler ways of designing the library than this.
Related-to #670