Update create_deployment() #640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
You'll need to rebase this on top of develop once #652 merges. |
ae408ef to
f9feeae
Compare
Contributor
Author
|
Done |
Contributor
|
Looks like flake8 (i.e line too long) failed on the integration test. |
Contributor
Author
|
Now it's a docstring issue. I'm not quite understanding the error. |
github3/repos/repo.py
Outdated
| tag, or sha. | ||
| :param bool force: Optional parameter to bypass any ahead/behind | ||
| checks or commit status checks. Default: False | ||
| :param list required_contexts Optional array of status contexts |
Owner
There was a problem hiding this comment.
The docs job is failing because you need this to be
:param list required_contexts: Optional array ...Not
:param list required_contexts Original array(Notice the : after required_contexts)
github3/repos/repo.py
Outdated
|
|
||
| @requires_auth | ||
| def create_deployment(self, ref, force=False, payload='', | ||
| def create_deployment(self, ref, required_contexts=[], payload='', |
Owner
There was a problem hiding this comment.
Even though we do no munging of parameter values, I would rather use None and then coerce it to an empty list inside the method. Using mutable default parameters is dangerous if we ever update this to munge required_contexts.
Contributor
Author
There was a problem hiding this comment.
I made the change in 75a264e.
Is that correct?
Owner
|
Perfect! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
according to https://developer.github.com/v3/repos/deployments/#create-a-deployment
I tried to update the tests for this, but didn't manage to. Any help or feedback would be appreciated.