Allow adding repos to teams with specific permissions #625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @borgstrom! @itsmemattchung would you have a chance to re-record the cassette that's failing for @borgstrom? |
|
@sigmavirus24 I fixed the test locally by simply editing the existing cassette and adding the new |
Yup - taking a look |
|
I'm re-recording the cassette, however, a single test is failing. This may be a local issue: tests/integration/test_orgs_team.py::TestTeam::test_add_member PASSED
tests/integration/test_orgs_team.py::TestTeam::test_add_repository FAILED
tests/integration/test_orgs_team.py::TestTeam::test_can_filter_members_by_role PASSED
tests/integration/test_orgs_team.py::TestTeam::test_delete PASSED
tests/integration/test_orgs_team.py::TestTeam::test_edit PASSED
tests/integration/test_orgs_team.py::TestTeam::test_has_repository PASSED
tests/integration/test_orgs_team.py::TestTeam::test_is_member PASSED
tests/integration/test_orgs_team.py::TestTeam::test_members PASSED
tests/integration/test_orgs_team.py::TestTeam::test_remove_member PASSED
tests/integration/test_orgs_team.py::TestTeam::test_remove_repository PASSED
tests/integration/test_orgs_team.py::TestTeam::test_repositories PASSEDI should have a new cassette recorded soon. |
|
Thanks @borgstrom . I merged the change and included the new cassette. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per: https://developer.github.com/v3/orgs/teams/#add-or-update-team-repository