Add support from squash on pull request merge #608
Conversation
| @@ -313,14 +313,16 @@ def issue_comments(self, number=-1, etag=None): | |||
| return self._iter(int(number), url, IssueComment, etag=etag) | |||
|
|
|||
| @requires_auth | |||
| def merge(self, commit_message='', sha=None): | |||
| def merge(self, commit_message='', squash=False, sha=None): | |||
There was a problem hiding this comment.
Please move squash to the end. Since sha was there first, someone might be doing:
pr.merge(my_message, sha)So squash should come last otherwise we will severely break existing code.
There was a problem hiding this comment.
done
On Thu, May 5, 2016 at 1:21 PM, Ian Cordasco notifications@github.com
wrote:
In github3/pulls.py
#608 (comment)
:@@ -313,14 +313,16 @@ def issue_comments(self, number=-1, etag=None):
return self._iter(int(number), url, IssueComment, etag=etag)@requires_auth
- def merge(self, commit_message='', sha=None):
- def merge(self, commit_message='', squash=False, sha=None):
Please move squash to the end. Since sha was there first, someone might
be doing:pr.merge(my_message, sha)
So squash should come last otherwise we will severely break existing code.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/sigmavirus24/github3.py/pull/608/files/6b9ef38131c0b535051c41131f04c5db575a8291#r62220756
There was a problem hiding this comment.
Although isn't this repo preparing for a 1.0 release, would this breaking change not be reasonable?
p.s. just fixed the unit tests, forgot to update unit tests
See https://developer.github.com/v3/pulls/#merge-a-pull-request-merge-button