Add License preview header to repository, to get a repository's license #592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Please do not remove the license method.Sent from my Android device with K-9 Mail. Please excuse my brevity. |
Author
|
I've restored the license method. |
| } | ||
|
|
||
| def _update_attributes(self, license): | ||
| self._api = license.get('url', '') |
Owner
|
Thanks so much @dsvetec! ✨ 🍰 ✨ |
Contributor
|
Awesome thanks @dsvetec |
Author
|
Thanks. I'm glad I could help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #591
I've added the
application/vnd.github.drax-preview+jsonmedia type when loading a repository so it loads with license data. The license data is partial (params: key, name, url & featured), so I've made some changes to load the whole license withlicense.refresh(). Because we can now retrieve the license this way, I saw no need in a seperate method to load the repository license. Therefore I removedrepo.license().