Initial commit for issues/585. #587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see the issue. By default, we match on the URI and body. However this requires we match |
Resolves: sigmavirus24#585 Added a custom betamax matcher for In-None-Match header
a32860f to
5c4d537
Compare
While I was testing the API, I wasn't use cassettes. Therefore, self.gh.repository() was not captured in the cassette.
e5d1c26 to
98bd122
Compare
98bd122 to
04c549c
Compare
| See: https://git.io/vaqIw | ||
|
|
||
| :param differs_from string: (optional), sha to compare against | ||
| :returns: strring of the SHA or None |
There was a problem hiding this comment.
strrings are grrreat ;)
Good eyeee :)
Replace strring with string in docstring. Simplified main method. Removed condition for checking resp
This is what I get for trying to code at 6:00AM
sigmavirus24
added a commit
that referenced
this pull request
Mar 11, 2016
Initial commit for issues/585.
|
Thanks @itsmemattchung ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #585
This reduces user rate limiting when a 304 response is returned