Removed tests/test_repos.py #565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -227,7 +227,7 @@ def download(self, path=''): | |||
| } | |||
| resp = self._get(self._api, allow_redirects=False, stream=True, | |||
| headers=headers) | |||
| if resp.status_code == 302: | |||
| if resp and resp.status_code == 302: | |||
There was a problem hiding this comment.
So _get and the other methods that proxy to requests always return a Response (unless requests itself raises an exception). We shouldn't need to check for None here since the only time we won't have a Response is in the exceptional case in which case we also won't be exercising this code. :)
|
Just a couple comments. |
Removed duplicated TestAsset in tests_repos_repos; TestAsset exists in test_repos_release. Added test_str, and test_download to TestAsset. Updated repos_asset_example's JSON.
Per @sigmavirus24, proxy to requests always return a response unless an exception is raised.
489230a to
167f8b6
Compare
|
@sigmavirus24 I made one modification and responded to the suggestions; let me know if you still want me to make those changes :) |
Per @sigmavirus24 directive
|
🌵 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed duplicated TestAsset in tests_repos_repos; TestAsset exists in
test_repos_release. Added test_str, and test_download to TestAsset.
Updated repos_asset_example's JSON.