Initial commit for license feature #477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: sigmavirus24#433 Added ability to retrieve license by name Added integration test for MIT license Added ability to retrieve repository's license
| @@ -107,6 +108,7 @@ def _update_attributes(self, repo): | |||
| self.id = repo.get('id', 0) | |||
| #: Language property. | |||
| self.language = repo.get('language', '') | |||
|
|
|||
There was a problem hiding this comment.
This is superfluous. Please remove it.
|
Just a couple nits and then I'm 👍 |
|
hey @sigmavirus24 thanks for the feedback. Going to walk the dogs then take a look when I'm back 🐶 🐶 |
|
@sigmavirus24 I appreciate the nits. Pushed an update based off of your feedback. |
Updated unit test for license to make sure attributes exist Removed empty whiteline in repo.py
ba71168 to
7f41fca
Compare
| # name of license | ||
| self.name = license.get('name') | ||
|
|
||
| # permission of license |
There was a problem hiding this comment.
One last nit, these comments are not exactly helpful.
There was a problem hiding this comment.
One last nit, these comments are not exactly helpful.
@sigmavirus24 attribute comments removed.
sigmavirus24
added a commit
that referenced
this pull request
Nov 13, 2015
Initial commit for license feature Closes #433
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #433
Added ability to retrieve license by name
Added integration test for MIT license
Added ability to retrieve repository's license