Migrate TestTree from tests/test_git.py to tests/integration + tests/unit #467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to call self.instance.recurse(), we need to add an integration test. After, we can then remove the class TestTree completely
| self.instance.recurse() | ||
| self.session.get.assert_called_once_with( | ||
| url_for(), | ||
| params={u'recursive': u'1'} |
There was a problem hiding this comment.
If you remove the u will this pass the tests on the other versions of Python? It should. This is causing the failure on Python 3.2.
|
A couple comments otherwise this looks 💯 @itsmemattchung! |
|
@sigmavirus24 just removed the unicode and now tests are passing. Going to look into changing the test data from the documentation and will ping you once I'm done with that. |
|
@sigmavirus24 I went ahead and updated the example with |
sigmavirus24
added a commit
that referenced
this pull request
Nov 8, 2015
Migrate TestTree from tests/test_git.py to tests/integration + tests/unit
|
🍰 Thanks @itsmemattchung ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Created a unit and integration test for github3.git.Tree. This is continuation of the ongoing objective of removing all tests that are not under
unitorintegration