8000 Use released packages for dev-dependencies by antoine-g · Pull Request #422 · sigmavirus24/github3.py · GitHub
[go: up one dir, main page]
Skip to content

Use released packages for dev-dependencies #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2015
Merged

Use released packages for dev-dependencies #422

merged 1 commit into from
Jul 28, 2015

Conversation

antoine-g
Copy link
Contributor

This fixes tests execution hanging because of tox trying to clone repositories it does not have access to.

I had to make this change to properly run the tests and I think that all the contributors except @sigmavirus24 have to also make this change. It should also be backward compatible for you.

Comments are welcomed :)

@sigmavirus24
Copy link
Owner

We should just use actual released versions. Probably want to figure out the latest versions of those projects released and do >={latest_version} since those likely have whatever bug fixes I was hoping to track.

@antoine-g
Use released versions in dev-requirements
5ea1575 
This commit replaces the dev dependencies declared as repositories by
the latest associated release of betamax and betamax_matchers.
@antoine-g antoine-g force-pushed the fix/dev-dependencies branch from 7ee5e36 to 5ea1575 Compare July 27, 2015 22:39
@antoine-g antoine-g changed the title Use HTTPS for dev-dependencies Use released packages for dev-dependencies Jul 27, 2015
sigmavirus24 added a commit that referenced this pull request Jul 28, 2015
@sigmavirus24
Merge pull request #422 from antoine-g/fix/dev-dependencies
87de595 
Use released packages for dev-dependencies
@sigmavirus24 sigmavirus24 merged commit 87de595 into sigmavirus24:develop Jul 28, 2015
@sigmavirus24
Copy link
Owner

Thanks @antoine-g

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antoine-g @sigmavirus24
0