8000 Add all_organizations to GitHub by antoine-g · Pull Request #421 · sigmavirus24/github3.py · GitHub
[go: up one dir, main page]
Skip to content

Add all_organizations to GitHub #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 27, 2015
Merged

Add all_organizations to GitHub #421

merged 1 commit into from
Jul 27, 2015

Conversation

antoine-g
Copy link
Contributor

This resolves #416.

  • New method
  • Integration test
  • Add the cassette JSON

@antoine-g antoine-g force-pushed the feature/list-all-orgs branch from 04cf3bf to 8000 e698d0e Compare July 27, 2015 17:11
sigmavirus24
sigmavirus24 reviewed Jul 27, 2015
View reviewed changes
tests/integration/test_github.py

assert isinstance(i, github3.issues.Issue)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you move this inside the context manager?

@sigmavirus24
Copy link
Owner

2 things:

  1. This is failing flake8 checks
  2. This needs unittests

@antoine-g
Add all_organizations to GitHub
8b5dacf 
- New method
- Integration test
- Add the cassette JSON
- Unit tests
@antoine-g antoine-g force-pushed the feature/list-all-orgs branch from e698d0e to 8b5dacf Compare 8000 July 27, 2015 17:40
@antoine-g
Copy link
Contributor Author

Everything should be ok now. Interestingly my python linter considered a line of length 80 valid.
Thanks for the feedback.

@sigmavirus24
Copy link
Owner

This looks great! Thanks @antoine-g

sigmavirus24 added a commit that referenced this pull request Jul 27, 2015
@sigmavirus24
Merge pull request #421 from antoine-g/feature/list-all-orgs
0182f89 
Add all_organizations to GitHub
@sigmavirus24 sigmavirus24 merged commit 0182f89 into sigmavirus24:develop Jul 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antoine-g @sigmavirus24
0