8000 Context data should be passed through to data dict by rco-ableton · Pull Request #371 · sigmavirus24/github3.py · GitHub
[go: up one dir, main page]
Skip to content

Context data should be passed through to data dict #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2015
Merged

Context data should be passed through to data dict #371

merged 1 commit into from
Apr 8, 2015

Conversation

rco-ableton
Copy link
Contributor

This patch fixes a bug where context was always being set to None regardless of the value passed to create_status.

@rco-ableton
Context data should be passed through to data dict
fb86851 
This patch fixes a bug where context was always being set to `None` regardless of the value passed to `create_status`.
@rco-ableton
Copy link
Contributor Author

(Apologies for not providing a test case, I'm short of time and it seems like a fairly obvious/trivial mistake in the code)

sigmavirus24 added a commit that referenced this pull request Apr 8, 2015
@sigmavirus24
Merge pull request #371 from rco-ableton/pass-through-context
787c22a 
Context data should be passed through to data dict
@sigmavirus24 sigmavirus24 merged commit 787c22a into sigmavirus24:develop Apr 8, 2015
@sigmavirus24
Copy link
Owner

Do you need this in 0.9?

@rco-ableton
Copy link
Contributor Author

@sigmavirus24 It would be good to have it if possible. I'm using a local modified copy now, but having the fix available through pip would be better for deployment.

@sigmavirus24
Copy link
Owner

Feel free to cherry-pick your fix to the stable/0.9 branch and send a PR

Sent from my Android device with K-9 Mail. Please excuse my brevity.

@rco-ableton
Copy link
Contributor Author

@sigmavirus24 #372 created; I matched 0.9's argument style rather than the newer style (i.e. passing an empty string vs. None).

@rco-ableton rco-ableton deleted the pass-through-context branch May 16, 2019 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rco-ableton @sigmavirus24
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
0