Fix typo in Repository JSON key 'forks_count' #268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should be 'forks_count' instead of 'fork_count' according to https://developer.github.com/v3/repos/#get.
|
Hi @tomiaijo! Thanks for submitting this! This is fixed in a separate branch which centralizes the work for version 1.0 of github3.py. Is this causing a lot of trouble for you? @jbarbuto already has a fix for this. Would a minor version of 0.9 help you both? I wasn't certain how common this was but it is starting to seem like it may be a problem a lot of people will run into. Thanks for this pull request and your input @tomiaijo (and of course for using github3.py)! |
|
I'd find it helpful, as my app's |
|
Version 0.9.1 is up on PyPI with this fix. Thank you both for working on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be 'forks_count' instead of 'fork_count' according to https://developer.github.com/v3/repos/#get.