Add Release.assets attribute #235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The JSON describing a release includes complete information on its assets. Add Release.assets attribute with a list of Assets. This is cheaper for the application than making a separate request via Release.iter_assets(). Leave Release.iter_assets() in place, in case someone has a use for it, but mention Release.assets in its documentation.
| @@ -104,7 +106,9 @@ def edit(self, tag_name=None, target_commitish=None, name=None, body=None, | |||
| return successful | |||
|
|
|||
| def iter_assets(self, number=-1, etag=None): | |||
| """Iterate over the assets available for this release. | |||
| """Iterate over the assets available for this release. The same | |||
There was a problem hiding this comment.
Let's revert the change to this doc-string. The same dynamic is present on Gists with a files and iter_files pair.
sigmavirus24
added a commit
that referenced
this pull request
May 3, 2014
Add Release.assets attribute
|
Thanks @bgilbert |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JSON describing a release includes complete information on its assets. Add
Release.assetsattribute with a list ofAssets. This is cheaper for the application than making a separate request viaRelease.iter_assets().Leave
Release.iter_assets()in place, in case someone has a use for it, but mentionRelease.assetsin its documentation.