8000 github3.py may not compatible with 3.8 · Issue #963 · sigmavirus24/github3.py · GitHub
[go: up one dir, main page]
Skip to content

github3.py may not compatible with 3.8 #963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dmerejkowsky opened this issue Jul 26, 2019 · 1 comment · Fixed by #964
Closed

github3.py may not compatible with 3.8 #963

dmerejkowsky opened this issue Jul 26, 2019 · 1 comment · Fixed by #964

Comments

@dmerejkowsky
Copy link
Contributor

Minimum Reproducible Example

Install tox then run:

$ tox -e py38
...
py38 run-test: commands[0] | py.test
  /.../github3/structs.py:11: 
  DeprecationWarning: 
  Using or importing the ABCs from 'collections' instead of from 'collections.abc' 
  is deprecated, and in 3.8 it will stop working
  
  class GitHubIterator(models.GitHubCore, collections.Iterator):

Which is weird is that it's still just a warning even when run with 3.8
@dmerejkowsky dmerejkowsky mentioned this issue Jul 26, 2019
Merged
@dmerejkowsky
Copy link
Contributor Author

Anyway, the fix was trivial so I went ahead and made a PR.

You may want to update the repository description afterwards :)

dmerejkowsky added a commit to dmerejkowsky/github3.py that referenced this issue Jul 26, 2019
@dmerejkowsky
Fix deprecation warning for 3.7 and up 82A2
3e81ad1 
Fix sigmavirus24#963
dmerejkowsky added a commit to dmerejkowsky/github3.py that referenced this issue Jul 26, 2019
@dmerejkowsky
Fix deprecation warning for 3.7 and up
9a21630 
Fix sigmavirus24#963
dmerejkowsky added a commit to dmerejkowsky/github3.py that referenced this issue Jul 29, 2019
@dmerejkowsky
Fix deprecation warning for 3.7 and up
dd210a3 
Fix sigmavirus24#963
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix deprecation warning for 3.7 and up dmerejkowsky/github3.py
1 participant
@dmerejkowsky
0