8000 pubsubhubbub method does not pass application/x-www-form-urlencoded header · Issue #545 · sigmavirus24/github3.py · GitHub
[go: up one dir, main page]
Skip to content

pubsubhubbub method does not pass application/x-www-form-urlencoded header #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jmathai opened this issue Jan 18, 2016 · 2 comments
Closed

pubsubhubbub method does not pass application/x-www-form-urlencoded header #545

jmathai opened this issue Jan 18, 2016 · 2 comments

Comments

@jmathai
Copy link
Contributor
jmathai commented Jan 18, 2016 •
edited by sigmavirus24
Loading

The pubsubhubbub method has a comment about the call needing to be form-data but it does not pass in a headers parameter which seems to default to application/json. The json parameter is set to False but that doesn't impact or set the headers.

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/29968400-pubsubhubbub-method-does-not-pass-application-x-www-form-urlencoded-header?utm_campaign=plugin&utm_content=tracker%2F183477&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F183477&utm_medium=issues&utm_source=github).
jmathai added a commit to jmathai/github3.py that referenced this issue Jan 18, 2016
@jmathai
sigmavirus24gh-545 Add content type header of application/x-www-form-…
02e8645 
…urlencoded to _post() call
jmathai added a commit to jmathai/github3.py that referenced this issue Jan 18, 2016
@jmathai
sigmavirus24gh-545 Add content type header of application/x-www-form-…
45ee2ba 
…urlencoded to _post() call
@jmathai jmathai mentioned this issue Jan 18, 2016
Merged
jmathai added a commit to jmathai/github3.py that referenced this issue Apr 5, 2016
@jmathai
sigmavirus24gh-545 Add content type header of application/x-www-form-…
78cce00 
…urlencoded to _post() call
@jmathai
Copy link
Contributor Author
jmathai commented Apr 5, 2016

The call to pubsubhubbub doesn't work because of this bug. The python 2.6 and 2.7 tests passed. There were some flake8 errors but I don't believe they are related to my changes.

Do you need anything before it can be merged?

jmathai added a commit to jmathai/github3.py that referenced this issue Apr 5, 2016
@jmathai
sigmavirus24gh-545 Add content type header of application/x-www-form-…
f54253e 
…urlencoded to _post() call
jmathai added a commit to jmathai/github3.py that referenced this issue Apr 5, 2016
@jmathai
sigmavirus24gh-545 Add content type header of application/x-www-form-…
9a6c23d 
…urlencoded to _post() call
jmathai added a commit to jmathai/github3.py that referenced this issue Apr 5, 2016
@jmathai
sigmavirus24gh-545 Add content type header of application/x-www-form-…
a29fcf7 
…urlencoded to _post() call
@jmathai jmathai closed this as completed Apr 5, 2016
@jmathai jmathai reopened this Apr 5, 2016
jmathai added a commit to jmathai/github3.py that referenced this issue Apr 5, 2016
@jmathai
sigmavirus24gh-545 Add content type header of application/x-www-form-…
7822c8d 
…urlencoded to _post() call
jmathai added a commit to jmathai/github3.py that referenced this issue Apr 6, 2016
@jmathai
sigmavirus24gh-545 Add content type header of application/x-www-form-…
772d047 
…urlencoded to _post() call
sigmavirus24 added a commit that referenced this issue Apr 7, 2016
@sigmavirus24
Merge pull request #546 from jmathai/content-type-gh-545
5c85bd1 
Add content-type header for pubsubhubbub call to _post (gh-545)
Sriharivignesh pushed a commit to Sriharivignesh/github3.py that referenced this issue Nov 18, 2017
@jmathai @Sriharivignesh
sigmavirus24gh-545 Add content type header of application/x-www-form-…
2e4c5b4 
…urlencoded to _post() call
@gabor-boros
Copy link

@omgjlk And another issue which can be closed, since #546 is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jmathai @sigmavirus24 @gabor-boros
0