10000 Add issue import beta endpoint(s) · Issue #497 · sigmavirus24/github3.py · GitHub
[go: up one dir, main page]
Skip to content
8000

Add issue import beta endpoint(s) #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sigmavirus24 opened this issue Dec 8, 2015 · 9 comments
Closed

Add issue import beta endpoint(s) #497

sigmavirus24 opened this issue Dec 8, 2015 · 9 comments
Labels
in progress

Comments

@sigmavirus24
Copy link
Owner
sigmavirus24 commented Dec 8, 2015 •
edited by omgjlk
Loading

https://gist.github.com/jonmagic/5282384165e0f86ef105
@itsmemattchung
Copy link
Contributor

@sigmavirus24 will take a stab at this and break it down into multiple PL

8000
@itsmemattchung
Copy link
Contributor

@sigmavirus24 , I'm trying to fit this into our proper module/namespace and could use your feedback.

As an example, here is the URI to import an issue:
https://api.github.com/repos/sigmavirus24/github3.py/import/issues

I thought of stuffing the the module inside of
github3/repo/import.py (class Issue) however that'll clash with the standard import statement and could cause some confusion with github3.issues.Issue

I also thought the Issue class is appropriate however the id in the response is the id of the import, not the actual issue itself (since the import can fail).

@sigmavirus24
Copy link
Owner Author

So, something like github3.repo.import.ImportedIssue would be good regardless of whether the issue is failed, pending, or imported. We can probably add a method to ImportedIssues to retrieve a github3.issues.Issue though.

Does that help?

@itsmemattchung
Copy link
Contributor

So, something like github3.repo.import.ImportedIssue would be good regardless of whether the issue is failed, pending, or imported. We can probably add a method to ImportedIssues to retrieve a github3.issues.Issue though.

Yup. Thanks @sigmavirus24

@itsmemattchung
Copy link
Contributor

So, @sigmavirus24 I created import.py under github3/repos/import.py but getting a SyntaxError when trying to import from repo.py.

from .import import ImportedIssue

E901 SyntaxError: invalid syntax

It doesn't like the name import (first time I've named a file import.py) - any thoughts on a different module name?
10000

@sigmavirus24
Copy link
Owner Author

issue_import.py?

@itsmemattchung
Copy link
Contributor

issue_import.py?

Simple enough - thanks

@itsmemattchung itsmemattchung mentioned this issue Jan 14, 2016
Merged
@itsmemattchung
Copy link
Contributor

Check list to track progress:

  • Ability to import an issue
  • Ability to check the status of an imported issue
  • Ability to check the status of multiple imported issues

@itsmemattchung
Copy link
Contributor

I'll tackle https://gist.github.com/jonmagic/5282384165e0f86ef105#check-status-of-multiple-issues this weekend. Should be able to close the issue after

itsmemattchung added a commit to itsmemattchung/github3.py that referenced this issue Jan 30, 2016
@itsmemattchung
Added ability to retrieve status of multiple imported issues
d1a7c0e 
Created unit and integration test for imported_issues

Closes: sigmavirus24#497
itsmemattchung added a commit to itsmemattchung/github3.py that referenced this issue Jan 30, 2016
@itsmemattchung
Added ability to retrieve status of multiple imported issues
435bea3 
Created unit and integration test for imported_issues

Closes: sigmavirus24#497
@itsmemattchung itsmemattchung mentioned this issue Jan 30, 2016
Merged
itsmemattchung added a commit to itsmemattchung/github3.py that referenced this issue Feb 2, 2016
@itsmemattchung
Added ability to retrieve status of multiple imported issues
f1cc6f5 
Created unit and integration test for imported_issues

Closes: sigmavirus24#497
itsmemattchung added a commit to itsmemattchung/github3.py that referenced this issue Feb 5, 2016
@itsmemattchung
Added ability to retrieve status of multiple imported issues
723bd8a 
Created unit and integration test for imported_issues

Closes: sigmavirus24#497
Sriharivignesh pushed a commit to Sriharivignesh/github3.py that referenced this issue Nov 18, 2017
@itsmemattchung @Sriharivignesh
Added ability to retrieve status of multiple imported issues
ae68b84 
Created unit and integration test for imported_issues

Closes: sigmavirus24#497
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sigmavirus24 @omgjlk @itsmemattchung
0