8000 Remove separate "internal error" from exec by freitagbr · Pull Request #802 · shelljs/shelljs · GitHub
[go: up one dir, main page]
Skip to content

Remove separate "internal error" from exec #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 29, 2018
Merged

Remove separate "internal error" from exec #802

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
54edcae
Remove separate "internal error" from exec
Nov 10, 2017
d588c63
Fix unknown command error regex
freitagbr Nov 11, 2017
cff9fdc
Add message about command not found regex
freitagbr Nov 16, 2017
dd7d42f
Silence errors while reading files in exec
freitagbr Nov 16, 2017
8201a60
Do not silence errors due to short timeouts
freitagbr Jan 12, 2018
e60e3b0
Simplify test regex for missing command
freitagbr Jan 28, 2018
5e79a99
Default error code to 1 if not set
freitagbr Jan 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Simplify test regex for missing command
  • Loading branch information
@freitagbr
freitagbr committed Jan 28, 2018
commit e60e3b03d855da3c74c1cb45d3f1c264c5f899dc
6 changes: 1 addition & 5 deletions test/exec.js
View file 756C
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,7 @@ test('config.fatal and unknown command', t => {
shell.config.fatal = true;
t.throws(() => {
shell.exec('asdfasdf'); // could not find command
// the expected message depends on where tests are run:
// /bin/sh says "foo: not found"
// /bin/bash says "foo: command not found"
// cmd.exe says "'foo' is not recognized..."
}, /((asdfasdf: not found)|(asdfasdf: command not found)|('asdfasdf' is not recognized))/);
}, /asdfasdf/); // name of command should be in error message
shell.config.fatal = oldFatal;
});

Expand Down
0