8000 refactor: change how internal errors are handled by nfischer · Pull Request #1222 · shelljs/shelljs · GitHub
[go: up one dir, main page]
Skip to content

refactor: change how internal errors are handled #1222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2025
Merged

refactor: change how internal errors are handled #1222

merged 1 commit into from
Apr 25, 2025

Conversation

nfischer
Copy link
Member

This is an internal refactor to change how we handle execa errors inside of shell.cmd().

This also adds a test case for a command which fails silently to make sure that we handle this case correctly.

@nfischer
refactor: change how internal errors are handled
9355761 
This is an internal refactor to change how we handle execa errors inside
of shell.cmd().

This also adds a test case for a command which fails silently to make
sure that we handle this case correctly.
@nfischer nfischer added refactor exec Issues specific to the shell.exec() API test coverage labels Apr 25, 2025
@codecov Codecov
Copy link
codecov bot commented Apr 25, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.47%. Comparing base (bfd06fa) to head (9355761).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1222   +/-   ##
=======================================
  Coverage   97.47%   97.47%           
=======================================
  Files          35       35           
  Lines        1463     1468    +5     
=======================================
+ Hits         1426     1431    +5     
  Misses         37       37

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nfischer nfischer merged commit 67a26e2 into main Apr 25, 2025
20 checks passed
@nfischer nfischer deleted the fix-execa-compat branch April 25, 2025 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
exec Issues specific to the shell.exec() API refactor test coverage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nfischer
0