8000 refactor: explicit handling for execa errors by nfischer · Pull Request #1220 · shelljs/shelljs · GitHub
[go: up one dir, main page]
Skip to content

refactor: explicit handling for execa errors #1220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2025
Merged

refactor: explicit handling for execa errors #1220

merged 1 commit into from
Apr 17, 2025

Conversation

nfischer
Copy link
Member

This adds a dedicated if-condition to handle internal errors from execa (timeout, maxBuffer, etc.) and to distinguish these from "regular" errors (the command executed, but it failed with non-zero status).

@nfischer
refactor: explicit handling for execa errors
ac55fff 
This adds a dedicated if-condition to handle internal errors from execa
(timeout, maxBuffer, etc.) and to distinguish these from "regular"
errors (the command executed, but it failed with non-zero status).
@nfischer nfischer added refactor exec Issues specific to the shell.exec() API test coverage labels Apr 10, 2025
@codecov Codecov
Copy link
codecov bot commented Apr 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.38%. Comparing base (75d26de) to head (ac55fff).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1220   +/-   ##
=======================================
  Coverage   97.37%   97.38%           
=======================================
  Files          35       35           
  Lines        1410     1414    +4     
=======================================
+ Hits         1373     1377    +4     
  Misses         37       37

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nfischer nfischer mentioned this pull request Apr 10, 2025
Closed
y-nk
y-nk approved these changes Apr 17, 2025
View reviewed changes
Copy link
Contributor
@y-nk y-nk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as you asked for my PoV, i think it's valid this way.

@nfischer nfischer merged commit 3149e09 into main Apr 17, 2025
20 checks passed
@nfischer
85B2 Copy link
Member Author

Thanks!

@nfischer nfischer deleted the cmd-internal-errors branch April 17, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y-nk y-nk y-nk approved these changes

Assignees
No one assigned
Labels
exec Issues specific to the shell.exec() API refactor test coverage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nfischer @y-nk
0