10000 fix(exec): lockdown file permissions by nfischer · Pull Request #1060 · shelljs/shelljs · GitHub
[go: up one dir, main page]
Skip to content

fix(exec): lockdown file permissions #1060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2022
Merged

fix(exec): lockdown file permissions #1060

merged 1 commit into from
Jan 7, 2022

Conversation

nfischer
Copy link
Member
@nfischer nfischer commented Jan 7, 2022

This locks down file permissions used by the internal implementation of
shell.exec().

Issue #1058
Tested manually using the documented scenarios

@nfischer
fix(exec): lockdown file permissions
118539f
10000 
This locks down file permissions used by the internal implementation of
`shell.exec()`.

Issue #1058
Tested manually using the documented scenarios
@codecov-commenter
Copy link
codecov-commenter commented Jan 7, 2022 •
edited
Loading

Codecov Report

Merging #1060 (118539f) into master (d0a4516) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1060   +/-   ##
=======================================
  Coverage   97.14%   97.15%           
=======================================
  Files          35       35           
  Lines        1332     1335    +3     
=======================================
+ Hits         1294     1297    +3     
  Misses         38       38
Impacted Files Coverage Δ
src/exec.js 95.06% <100.00%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0a4516...118539f. Read the comment docs.

@nfischer nfischer merged commit 003a39d into master Jan 7, 2022
@nfischer nfischer deleted the exec-lockdown-perms branch January 7, 2022 05:14
nfischer added a commit that referenced this pull request Jan 7, 2022
@nfischer
fix(exec): lockdown file permissions (#1060)
d919d22 
This locks down file permissions used by the internal implementation of
`shell.exec()`.

Issue #1058
Tested manually using the documented scenarios
@nfischer nfischer linked an issue Jan 7, 2022 that may be closed by this pull request
Trying to get in touch regarding a security issue #1058
Closed
@nfischer nfischer added this to the v0.8.5 milestone Jan 7, 2022
@nfischer nfischer mentioned this pull request Jan 7, 2022
Closed
@github-actions github-actions bot mentioned this pull request Jan 12, 2022
Closed
@ibrayo1 ibrayo1 mentioned this pull request Jan 12, 2022
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Jan 15, 2022
Closed
@techeverri techeverri mentioned this pull request Jan 18, 2022
Closed
@monicawheeler monicawheeler mentioned this pull request Jan 19, 2022
Merged
@sync-by-unito sync-by-unito bot mentioned this pull request Jan 22, 2022
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Feb 1, 2022
Closed
@stefanobaghino-da stefanobaghino-da mentioned this pull request Feb 14, 2022
Merged
7 tasks
This was referenced May 10, 2022
Closed
Closed
@scott-es scott-es mentioned this pull request May 11, 2022
Closed
@github-actions github-actions bot mentioned this pull request May 12, 2022
Closed
This was referenced May 13, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced May 17, 2022
Closed
Closed
@github-actions github-actions bot mentioned this pull request May 18, 2022
Open
@scott-es scott-es mentioned this pull request May 21, 2022
Closed
This was referenced May 26, 2022
Closed
Closed
Open
This was referenced May 6, 2022
Open
Open
This was referenced Mar 7, 2023
Open
Open
Open
jchip pushed a commit to jchip/shcmd that referenced this pull request Jun 23, 2024
@nfischer @jchip
fix(exec): lockdown file permissions (shelljs#1060)
872e46d 
This locks down file permissions used by the internal implementation of
`shell.exec()`.

Issue shelljs#1058
Tested manually using the documented scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.8.5
Development

Successfully merging this pull request may close these issues.

Trying to get in touch regarding a security issue
2 participants
@nfischer @codecov-commenter
0