Drop Python 3.8 support, require Python 3.9+ #2084
Conversation
With the migration to Shapely 2.0 successfully completed and Python 3.13 soon coming in, this seems like a good moment to drop Python 3.8 support. It's almost [end-of-life](https://endoflife.date/python) and [SPEC 0](https://scientific-python.org/specs/spec-0000/) already recommended dropping Python 3.8 over a year ago. So this PR bumps the required Python version to 3.9, removes 3.8 from the CI and test files. Of course this will only affect future releases from the main branch, existing releases and releases from maintenance branches (like maint-2.0) stay compatible with Python 3.8 and can continued to be used.
Pull Request Test Coverage Report for Build 9889471302Details
💛 - Coveralls |
|
The linting error is a bit weird. It are multiple cases of flake8 throwing a What I find strange, is why is it showing up now. |
|
Couldn't pinpoint what's happening exactly, but on Python 3.11, the flake8 linting job passes without problem, so let's use that for this PR. Probably somehow related to PyCQA/flake8#1845. The Windows error seems unrelated, please re-run that job. |
Each new Python release contains subtle changes to the parser. Python 3.12 specifically contains changes to f-string parsing, and may include other parser changes. This would mean that what was once a string is now parsed as a string containing an expression. The linter would then have access to this new information and provide more detailed feedback. My suggestion would be to always use the latest Python release for linting and correct any new linter errors that pop up. Of course, you can do this in a different PR if you want to keep this one focused. |
|
Hi @EwoutH, apologies for the delay. We'll drop at least Python 3.8, but perhaps more. I'm not sure where a discussion should be held (there could already be an issue for it, I can't recall). Essentially, I'd like to see adoption for SPEC 0 but retain compatibility with older/supported GEOS versions. I'll add a review here soon. |
With the migration to Shapely 2.0 successfully completed and Python 3.13 soon coming in, this seems like a good moment to drop Python 3.8 support. It's almost end-of-life and SPEC 0 already recommended dropping Python 3.8 over a year ago.
So this PR bumps the required Python version to 3.9, removes 3.8 from the CI and test files.
Of course this will only affect future releases from the main branch, existing releases and releases from maintenance branches (like
maint-2.0) stay compatible with Python 3.8 and can continued to be used.