8000 new mono drivingfunction handling by fs446 · Pull Request #125 · sfstoolbox/sfs-python · GitHub
[go: up one dir, main page]

Skip to content

new mono drivingfunction handling #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Mar 13, 2019
Prev Previous commit
Next Next commit
__init.py__, soundfigure into wfs handling
  • Loading branch information
fs446 committed Mar 12, 2019
commit bcc8239bfe1b8c8d45d73f38b8e31cc366d9676a
26 changes: 22 additions & 4 deletions sfs/mono/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,20 +9,38 @@
wfs

source
soundfigure

"""
from . import source as _source


def secondary_source_point(omega, c):
"""Create a point source for use in `sfs.mono.synthesize()`."""

def secondary_source(position, _, grid):
return _source.point(omega, position, grid, c)

return secondary_source


def secondary_source_line(omega, c):
"""Create a line source for use in `sfs.mono.synthesize()`."""

def secondary_source(position, _, grid):
return _source.line(omega, position, grid, c)

return secondary_source


import numpy as _np

from . import source

from . import esaedge
from . import nfchoa
from . import sdm
from . import wfs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could move those 4 import statements to the very bottom of the file, to make clear that they are not needed in the code below.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ordering seems to make a difference
this works:
9a7b091

def below the imports not.


from . import source
from . import soundfigure

from .. import array as _array


Expand Down
Loading
0