E52E android: Add UI setting for experimental features by jdm · Pull Request #40054 · servo/servo · GitHub
[go: up one dir, main page]
Skip to content

android: Add UI setting for experimental features #40054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jdm merged 2 commits into from
Oct 22, 2025
Merged

android: Add UI setting for experimental features #40054

jdm merged 2 commits into from
Oct 22, 2025

Conversation

@jdm
Copy link
Member
@jdm jdm commented Oct 21, 2025

These commits add a new settings screen to the app, then add:

  1. a setting to disable a developer-targeted UI element (an indicator about whether the app is polling continuously for events)
  2. a toggle for experimental web platform features

The page needs to be reloaded after switching the toggle before any changes can be observed.

Testing: Manually tested by visiting https://developer.mozilla.org with the setting enabled and disabled. No automated testing for Android yet.
Fixes: #39791

@jdm
android: Add settings screen.
70bc925 
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
@jdm jdm requested a review from jschwe as a code owner October 21, 2025 07:38
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Oct 21, 2025
@jdm
Copy link
Member Author
jdm commented Oct 21, 2025

Note: I have no practical Android development experience, so I'm cobbling together these changes based on reading the developer documentation and assorted tutorials and example code, then fitting them into the architecture of the app as it exists today (servo/book#143).

My hope is that these quality of life improvements will push the app over the edge into being just useful enough for testing that actual Android developers will feel compelled to clean it up.

mukilan
mukilan approved these changes Oct 21, 2025
View reviewed changes
Copy link
Member
@mukilan mukilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice!

@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Oct 21, 2025
@jdm
android: Add setting to control experimental web platform features.
fc4be3f 
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
@jdm jdm force-pushed the android-experimental-button branch from 6bda160 to fc4be3f Compare October 22, 2025 12:47
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Oct 22, 2025
@jdm jdm enabled auto-merge October 22, 2025 12:47
@jdm jdm added this pull request to the merge queue Oct 22, 2025
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Oct 22, 2025
Merged via the queue into servo:main with commit 8554459 Oct 22, 2025
33 checks passed
@jdm jdm deleted the android-experimental-button branch October 22, 2025 14:14
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mukilan mukilan mukilan approved these changes

@jschwe jschwe Awaiting requested review from jschwe jschwe is a code owner

Assignees

No one assigned

Labels

S-awaiting-review There is new code that needs to be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add UI toggle for experimental web features to Android UI

3 participants

@jdm @mukilan @servo-highfive
0