canvas: Move font selection and text shaping to script
#38979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔨 Triggering try run (#17276595993) for Linux (WPT) |
|
Test results for linux-wpt from try job (#17276595993): Flaky unexpected result (19)
Stable unexpected results that are known to be intermittent (24)
Stable unexpected results (3)
|
|
|
nicoburns
approved these changes
Aug 27, 2025
sagudev
approved these changes
Aug 28, 2025
|
For a follow up we should extraact |
Instead of doing font selection and text shaping in `canvas`, move this to `script`. This allows canvas to use the shared `Document` `FontContext`, which has access to web fonts. In addition, ensure that there is a font style accessible for `OffscreenCanvas` in workers. Signed-off-by: Martin Robinson <mrobinson@igalia.com>
1a8879b to
1706189
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 28, 2025
Instead of doing font selection and text shaping in `canvas`, move this to `script`. This allows canvas to use the shared `Document` `FontContext`, which has access to web fonts. In addition, ensure that there is a font style accessible for `OffscreenCanvas` in workers. Testing: This causes a number of WPT tests to start to pass as web fonts are supported on canvas again. In addition, some start to fail as they expose other issues: - The lack of support for the `Context2D.fontStretch` property - Issues with zerosize gradient interpolation. - Differences between quoted and unquoted font family names. This seems like a timing issue with the way we are handling web fonts. The test seems to be expecting Local fonts to be available immediately (without waiting for them to load). This isn't how Servo works ATM. Seems like an issue with the test. Signed-off-by: Martin Robinson <mrobinson@igalia.com>
mrobinson
added a commit
that referenced
this pull request
Aug 28, 2025
…bgpu)
{"fail_fast": false, "matrix": [{"name": "Linux (Production, WPT)", "workflow": "linux", "wpt": true, "profile": "production", "unit_tests": false, "build_libservo": false, "bencher": false, "build_args": "", "wpt_args": "_webgpu", "number_of_wpt_chunks": 20}]}
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 29, 2025
This was (presumably accidentally) added in #38979, cc @mrobinson Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of doing font selection and text shaping in
canvas, move thisto
script. This allows canvas to use the sharedDocumentFontContext, which has access to web fonts. In addition, ensure thatthere is a font style accessible for
OffscreenCanvasin workers.Testing: This causes a number of WPT tests to start to pass as web fonts are
supported on canvas again. In addition, some start to fail as they expose other
issues:
Context2D.fontStretchpropertya timing issue with the way we are handling web fonts. The test seems to be
expecting Local fonts to be available immediately (without waiting for them
to load). This isn't how Servo works ATM. Seems like an issue with the test.