8000 layout: Skip adding `ScrollFrameHitTestItem` to stacking context tree if the `BoxFragment` has inherited style `pointer-events: none` by kongbai1996 · Pull Request #38884 · servo/servo · GitHub
[go: up one dir, main page]
Skip to content

layout: Skip adding ScrollFrameHitTestItem to stacking context tree if the BoxFragment has inherited style pointer-events: none #38884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 23, 2025
Merged

layout: Skip adding ScrollFrameHitTestItem to stacking context tree if the BoxFragment has inherited style pointer-events: none #38884

merged 2 commits into from
Aug 23, 2025

Conversation

kongbai1996
Copy l 8000 ink
Contributor
@kongbai1996 kongbai1996 commented Aug 23, 2025 •
edited
Loading

fix some page cannot slide
In the refactoring of #38480, a segment of logic was missing.

servo/components/layout/display_list/mod.rs

Lines 405 to 410 in 11844ca

use style::computed_values::pointer_events::T as PointerEvents;
let inherited_ui = style.get_inherited_ui();
if inherited_ui.pointer_events == PointerEvents::None {
return None;
}

Testing: The page can be scrolled on the OpenHarmony device.
Fixes: #38480 (comment)

@kongbai1996
fix some page cannot slide
cc3fe56 
Signed-off-by: kongbai1996 <1782765876@qq.com>
@yezhizhen yezhizhen self-requested a review August 23, 2025 04:01
yezhizhen
yezhizhen approved these changes Aug 23, 2025
View reviewed changes
Copy link
Member
@yezhizhen yezhizhen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me. I made similar change before for hit-test in webdriver according to spec.

https://github.com/servo/servo/pull/38383/files

@yezhizhen yezhizhen changed the title fix some page cannot slide layout: Skip adding ScrollFrameHitTestItem to stacking context tree if the BoxFragment has pointer-events: none Aug 23, 2025
@yezhizhen
Copy link
Member

@kongbai1996 I changed the title. Does it make sense?

@yezhizhen yezhizhen added the T-webdriver Do a try run of WebDriver tests. label Aug 23, 2025
@github-actions github-actions bot removed the T-webdriver Do a try run of WebDriver tests. label Aug 23, 2025
@github-actions GitHub Actions
Copy link

🔨 Triggering try run (#17171079551) for Linux (WPT)

@yezhizhen yezhizhen changed the title layout: Skip adding ScrollFrameHitTestItem to stacking context tree if the BoxFragment has pointer-events: none layout: Skip adding ScrollFrameHitTestItem to stacking context tree if the BoxFragment has inherited style pointer-events: none Aug 23, 2025
@github-actions GitHub Actions
Copy link

Test results for linux-wpt from try job (#17171079551):

Flaky unexpected result (3)
  • OK /webdriver/tests/classic/forward/forward.py
    • PASS [expected FAIL] subtest: test_removed_iframe
  • OK /webdriver/tests/classic/get_alert_text/get.py
    • FAIL [expected PASS] subtest: test_get_confirm_text

      AssertionError: no such alert (404): No user prompt is currently active.

    • FAIL [expected PASS] subtest: test_get_prompt_text

      AssertionError: assert 'Hello' == 'Enter Your Name: '

  • OK /webdriver/tests/classic/take_element_screenshot/iframe.py
    • FAIL [expected PASS] subtest: test_source_origin[cross_origin]

      AssertionError: assert 'iVBORw0KGgoAAAANSUhEUgAAAMgAAADICAYAAACtWK6eAAAFaklEQVR4Ae3AA6AkWZbG8f937o3IzKdyS2Oubdu2bdu2bdu2bWmMnpZKr54yMyLu+Xa3anqmhztr1a/aNlddddXzQ+Wqq656QahcddVVLwiVq6666gWhctVVV70gVK666qoXhMpVV131glC56qqrXhAqV1111QtC5aqrrnpBqFx11VUvCJWrrrrqBaFy1VVXvSBUrrrqqheEylVXXfWCULnqqqteECpXXXXVC0LlqquuekGoXHXVVS8IlauuuuoFoXLVVVe9IFSuuuqqF4TKVVdd9YJQueqqq14QKlddddULQuWqq656QahcddVVLwiVq6666gWhctVVV70gVK666qoXhMpVV131glC56qqrXhAqV1111QtC5aqrrnpBqFx11VUvCJWrrrrqBaFy1VVXvSBUrrrqqheEylVXXfWCULnqqqteECpXXXXVC0LlqquuekGoXHXVVS8IlauuuuoFoXLVVVe9IFSuuuqqF4TKVVdd9YJQueqqq14QKlddddULQuWqq656QahcddVVLwiVq6666gWhctVVV70gVK666qoXhMpVV131glC56qqrXhAqV1111QtC5aqrrnpBqFx11VUvCJWrrrrqBaFy1VVXvSBUrrrqqheEylVXXfWCULnqqqteECpXXXXVC0LlqquuekGoXHXVVS8IlauuuuoFoXLVVVe9IFSuuuqqF4TKVVdd9YJQueqqq14QKlddddULQuWqq656QahcddVVLwiVq6666gWhctVVV70gVK666qoXhMpVV131glC56qqrXhAqV1111QtC5aqrrnpBqFx11VUvCJWrrrrqBaFy1VVXvSBUrrrqqheEylVXXfWCULnqqqteECpXXXXVC0LlqquuekGoXHXVVS8IlauuuuoFoXLVVVe9IFSuuuqqF4TKVVdd9YJQueqqq14QKlddddULQuWqq656QahcddVVLwiVq6666gWhctVVV70gVK666qoXhMpVV131glC56qqrXhAqV1111QtC5aqrrnpBqFx11VUvCJWrrrrqBaFy1VVXvSBUrrrqqheEylVXXfWCULnqqqteECpXXXXVC0LlqquuekGoXHXVVS8IlauuuuoFoXLVVVe9IFSuuuqqF4TKVVdd9YJQueqqq14QKlddddULQuWqq656QahcddVVLwiVq6666gWhctVVV70gVK666qoXhMpVV131glC56qqrXhAqV1111QtC5aqrrnpBqFx11VUvCJWrrrrqBaFy1VVXvSBUrrrqqheEylVXXfWCULnqqqteECpXXXXVC0LlqquuekGoXHXVVS8IlauuuuoFoXLVVVe9IFSuuuqqF4TKVVdd9YJQueqqq14QKlddddULQuWqq656QahcddVVLwiVq6666gWhctVVV70gVK666qoXhMpVV131glC56qqrXhAqV1111QtC5aqrrnpBqFx11VUvCJWrrrrqBaFy1VVXvSBUrrrqqheEylVXXfWCULnqqqteECpXXXXVC0LlqquuekGoXHXVVS8IlauuuuoFoXLVVVe9IFSuuuqqF4TKVVdd9YJQueqqq14QKlddddULQuWqq656QahcddVVLwiVq6666gWhctVVV70gVK666qoXhMpVV131glC56qqrXhAqV1111QtC5aqrrnpBqFx11VUvCJWrrrrqBaFy1VVXvSBUrrrqqheEylVXXfWCULnqqqteECpXXXXVC0LlqquuekGoXHXVVS8IlauuuuoFoXLVVVe9IFSuuuqqF4TKVVdd9YJQueqqq14QKlddddULQuWqq656QahcddVVLwiVq6666gWhctVVV70gVK666qoXhMpVV131glC56qqrXhD+ETibBx2wK4avAAAAAElFTkSuQmCC' == 'iVBORw0KGgoAAAANSUhEUgAAAMgAAADICAYAAACtWK6eAAAN2klEQVR4Ae3AA6AkWZbG8f937o3IzKdyS2Oubdu2bdu2bdu2bWmMnpZKr54yMyLu+Xa3anqmhztr1a/y2Zir/sfwZ5mr/segctVVV70gVK666qoXhMoe8JU8pzcGXpmrrvr/jmAH+GzgpYEe+GzglbnqqquAylVXXfWCUPm3eArw28A9QAc8AngDYJsr/hT4Ra54U+A+4B+AJfDiwNtzxZOA3wbuA2bAY4A3AGbAnwK/yBVvDpwF/hqYAa8NvBTwK8DfAHPgtYCX5aqr/iMR/Gs9CfgB4CHAxwLvB5wHvgtYc8UrAp/KFX8IPAT4GOBNebYnAD8EPAL4OOA9gFuBHwYMvCLwqVzx58DDgY8FXhz4OeDngIcBHwu8OPDzwC5XXfUfieBf61eBM8DrARvAaeAtgAvAn/G8Hgq8GNADrwi8PVf8GnAGeB1gAVwHvCHwdOBWntMNwCOAGfDKgIEEHgXMgFcGEridq676j0Twr7EHnAMezHO6DpgBT+N5Xcvz2gPOAw/mOd3IFU/jOV3Ds21yxTU82xZXHHHVVf+RqPxrHHHFgue1ARzxvDqe1xFX/CnwpzyvSzynnmcTV/Q8m7jCXHXVfyQq/xobXLHkeR0BJ3jRbHDFqwFvwFVX/U9F8KL4fuBWYAc4DdzKc7oHWAMP5UWzA5wG7uJ5fRPw91x11f8EBP9abwicBX4DOALOAT8HnARegRfdGwHPAH4fOAKOgF8BEng0V131PwHiYzFfyb/svYEHc8VTgN8C7gU64BHAGwDbXPH3wI/znD4ZmPOcngr8FnAPMAceArwBsAP8PfDjPNtLAi8NfC/P9ljgFYHv5tkeCrwn/2v5s8xV/2MgPhtz1f8Y/ixz1f8YVK666qoXhMpVV131glC56qqrXhAqV1111QtC5aqrrnpBCABuA74EOMtVV131bFQAzBXm/66/BH6WK94ceHledL8O/D5XvDvwcK76/4EA4EHAJwHX8H/XywKfzr/N6wMfzlX//1C56qqrXhAqfwr8Ile8JfCywK8Dv88Vbws8EXgyUICXBN4AqFxxAfgV4HZgAh4KvDpwE/DLwB9zxYcC1wCPA36UK94WeEngT4Ff5Io3B84Cfw3MgNcGXgr4FeBvgDnwWsDL8i/7U+APgCPgRuBNeP6eAvw2cA/QAY8A3gDY5l/2FOC3gXuADngE8AbANlf8KfCLXPGmwH3APwBL4MWBt+eq/7kIXhH4VJ7T6wMfzhW/BbwE8HHAWwJ/Cfwqz/ajQAd8GPCxwHHge7nijYH35Dk9FvhEntMrAp/KFX8OPBz4WODFgZ8Dfg54GPCxwIsDPw/s8sL9HfCLwMsBHwu8EfBrPK8nAT8APAT4WOD9gPPAdwFrXrgnAT8APAT4WOD9gPPAdwFrrnhF4FO54g+BhwAfA7wpV/3PR/AveSzwaGAGPAZ4WeAvgD1gAu4BHgNsAnPgDYGOf7sbgEcAM+CVAQMJPAqYAa8MJHA7L9xvA9cBrwksgOuBl+N5/SpwBng9YAM4DbwFcAH4M164XwXOAK8HbACngbcALgB/xvN6KPBiQA+8IvD2XPU/G8G/5Aae0y1AA+4GKnAj8OvAPwAjEMAn8G93Dc+2yRXX8GxbXHHEC7YEzgO38Jxu4jntAeeAB/OcrgNmwNN4wfaAc8CDeU7XATPgaTyva7nqfxcq/5IZz2mDK/a54t2B3wV+GfhJ4KHAawE38W/T82ziip5nE1eYF2yfKxY8pwXP6YgrFjyvDeCIF+yIKxY8rw3giOfVcdX/LgT/kiXP6YgrtrliAbwR8HHA+wAT8F3ABa4QVzSebc1/rm2uWPKcVjynDa5Y8ryOgA1esA2uWPK8joANrvrfj+BfcifP6TagADcAB8A38mw3AW8JNOAurtjgigOe7V7+cy2AU8BtPKe7eU47wGngVp7TPcAaeCgv2A5wGriV53QPsAYeylX/+xH8S54OPAFYA48H/hJ4OWCbK+4D/ghYAyvgz4EK3MgVp4BN4M+AJXAO+Gv+8702cA/wu8ASuBf4A57XGwJngd8AjoBzwM8BJ4FX4IV7Q+As8BvAEXAO+DngJPAKXPW/H+JNMb/Isz0YeG/gHPD1wDsCTwSeAATwEsAbApUrngT8CXA30IBrgdcBHsKzPQ34JWAXuBF4Q+BbueLhwEsDP86zvSTw0sD38myPBV4R+G6e7aHAe/KC/Rnw+8AhcB3wRsB3cMVNwPtzxVOA3wLuBTrgEcAbANtc8evA7/NsLwm8LVc8Bfgt4F6gAx4BvAGwzRV/D/w4z+mTgTnPlz/LXPU/BuKzMc/POeDrgXcHHs5V/0X8Weaq/zGoXHXVVS8Ilefn14Hf54rvB14SeFuuuur/GyrPz+sDr89VV/1/R+Wqq656QQheFLcBXwKc5aqr/j8heFGYK8yzPQ34bOA+/vd4GvDZwH1cddWLgsqL4kHAJ3HVVf/fULnqqqteECoAF4BfAW4HJuChwKsDNwF/CvwiV7wl8LLArwO/zxXfyBXHgY/m+TsCfh94ArAHnAZeG3g0z/anwC9yxZsDZ4G/BmbAawMvBfwK8DfAHHgt4GV5Tk8Cfhu4D5gBjwHeAJgBvw78Pld8I1ccBz6aq656QRCfjflm4DTwJkABfhv4S+BTuWIAvhB4S+BlueJpwPcCHwpcwwv3y1zxmkAFngD8LPCBwDU82wB8IXAd8HrALcDvAH8EvBTwGODBwO8CfwR8JHCcK54A/AjwmsArA5eAHwe2gfcEBDwN+F7gQ4Fr+B/Jn2Wu+h+DYALuAR4DbAJz4A2Bjv84bwy8MbAB9MBLAg8D/pTn7wbgEcAMeGXAQAKPAmbAKwMJ3M6z/RpwBngdYAFcB7wh8HTgVq666t+CoAI3Ar8O/AMwAgF8Av+5FsB5nr9reLZNrriGZ9viiiOu2APOAw/mOd3IFU/jqqv+LagAvDvwu8AvAz8JPBR4LeAm/mOcBX4TuB04BMwV1/H89TybuKLn2cQV5oojrvhT4E95Xpe46qp/CyoAC+CNgDcC7gB+A/gu4MOAk/z7NOB7gW3gvYGTQAA/DdzDf4wNrng14A246qr/KAQHwDfybDcBbwk04C5eMPGiuQjsAy8OnAaCKyb+4+wAp4G7eF7fBPw9V4irrvrXIAC4D/gjYA2sgD8HKnAjL9gWV5wDjoAv5/k7DmwCfwOcBSbgqcBT+I/1RsAzgN8HjoAj4FeABB7NFVtccQ44Ar4cuAv4M+CzgV/nqqseCPHZmCcBfwLcDTTgWuB1gIcAfwr8Is/2YOC9ueIXgL8DDLwk8GY8f3cCvwrcDSyAhwNL4HFc8fHArcCP82wvCbw08L0822OBVwS+m2d7KPCeXPFU4LeAe4A58BDgDYAdnu0XgL8DDLwk8GbAnwG/ALwm8Lr8t/Jnmav+x0B8Nuaq/zH8Weaq/zGoXHXVVS8IlauuuuoFoXLVVVe9IFSuuuqqF4TKVVdd9YJQueqqq14QKlddddULQuWqq656QahcddVVLwiVq6666gWhctVVV70gVK666qoXhMpVV131glC56qqrXhAqV1111QtC5aqrrnpBqFx11VUvCJWrrrrqBaFy1VVXvSBUrrrqqheEylVXXfWCULnqqqteECpXXXXVC0LlqquuekGoXHXVVS8IlauuuuoFoXLVVVe9IFSuuuqqF4TKVVdd9YJQueqqq14QKlddddULQuWqq656QahcddVVLwiVq6666gWhctVVV70gVK666qoXhMpVV131glC56qqrXhAqV1111QtC5aqrrnpBqFx11VUvCJWrrrrqBaFy1VVXvSBUrrrqqheEylVXXfWCULnqqqteECpXXXXVC4Jsm6uuuur5oXLVVVe9IFSuuuqqF4TKVVdd9YJQueqqq14QKlddddULQuWqq656QahcddVVLwiVq6666gWhctVVV70gVK666qoXhMpVV131glC56qqrXhAqV1111QtC5aqrrnpBqFx11VUvCJWrrrrqBaFy1VVXvSBUrrrqqheEylVXXfWCULnqqqteECpXXXXVC0LlqquuekGoXHXVVS8IlauuuuoFoXLVVVe9IFSuuuqqF4TKVVdd9YJQueqqq14QKlddddULQuWqq656QahcddVVLwiVq6666gWhctVVV70gVK666qoXhMpVV131glC56qqrXhAqV1111QtC5aqrrnpBqFx11VUvCJWrrrrqBaFy1VVXvSBUrrrqqheEylVXXfWCULnqqqteECpXXXXVC0LlqquuekGoXHXVVS8IlauuuuoFoXLVVVe9IFSuuuqqF4TKVVdd9YJQueqqq14QKlddddULQuWqq656QahcddVVLwiVq6666gWhctVVV70gVK666qoXhMpVV131glC56qqrXhAqV1111QtC5aqrrnpBqFx11VUvCJWrrrrqBaFy1VVXvSBUrrrqqheEylVXXfWCULnqqqteECpXXXXVC0LlqquuekGoXHXVVS8IlauuuuoFoXLVVVe9IFSuuuqqF4TKVVdd9YJQueqqq14QKlddddULQuWqq656QahcddVVLwiVq6666gWhctVVV70gVK666qoXhMpVV131glC56qqrXhAqV1111QtC5aqrrnpBqFx11VUvCJWrrrrqBaFy1VVXvSBUrrrqqheEylVXXfWCULnqqqteECpXXXXVC0LlqquuekGoXHXVVS8IlauuuuoFoXLVVVe9IFSuuuqqF4TKVVdd9YLwjw2M8o0UG8LnAAAAAElFTkSuQmCC'

Stable unexpected results that are known to be intermittent (1)
  • TIMEOUT [expected OK] /webdriver/tests/classic/perform_actions/navigation.py (#38822)
Stable unexpected results (3)
  • OK /webdriver/tests/classic/accept_alert/accept.py
    • FAIL [expected PASS] subtest: test_accept_in_popup_window

      AssertionError: no such alert (404): No user prompt is currently active.

  • OK /webdriver/tests/classic/close_window/close.py
    • FAIL [expected PASS] subtest: test_element_usage_after_closing_browsing_context

      webdriver.error.NoSuchWindowException: no such window (404): No such window

  • OK /webdriver/tests/classic/perform_actions/key_shortcuts.py
    • FAIL [expected PASS] subtest: test_mod_a_mod_c_right_mod_v_pastes_text

      AssertionError: assert 'abc d' == 'abc dabc d'

@github-actions GitHub Actions
Copy link

⚠️ Try run (#17171079551) failed.

@yezhizhen
Copy link
Member
yezhizhen commented Aug 23, 2025 •
edited
Loading

⚠️ Try run (#17171079551) failed.

Oh why CI finishes so fast now.. The release build only takes 3mins?

cc @jschwe @sagudev

@jschwe
Copy link
Member
jschwe commented Aug 23, 2025

We have some self-hosted runners, which are much faster than the GitHub hosted ones, but obviously a limited resource. I think we have two servers at the moment.

@kongbai1996 @yezhizhen
Update components/layout/display_list/stacking_context.rs
0f26923 
Co-authored-by: Euclid Ye <yezhizhenjiakang@gmail.com>
Signed-off-by: Fuguo <1782765876@qq.com>
yezhizhen
yezhizhen approved these changes Aug 23, 2025
View reviewed changes
Copy link
Member
@yezhizhen yezhizhen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The webdriver result looks good.

@yezhizhen yezhizhen enabled auto-merge August 23, 2025 06:28
@yezhizhen yezhizhen added this pull request to the merge queue Aug 23, 2025
Merged via the queue into servo:main with commit 7dc4846 Aug 23, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yezhizhen yezhizhen yezhizhen approved these changes

@mrobinson mrobinson Awaiting requested review from mrobinson mrobinson is a code owner

@Loirooriol Loirooriol Awaiting requested review from Loirooriol Loirooriol is a code owner

@nicoburns nicoburns Awaiting requested review from nicoburns

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kongbai1996 @yezhizhen @jschwe
0