8000 Upgrade to SpiderMonkey 140. by jdm · Pull Request #38563 · servo/servo · GitHub
[go: up one dir, main page]

Skip to content

Conversation

jdm
Copy link
Member
@jdm jdm commented Aug 8, 2025

Upgrade to use the latest mozjs upgrade.

Testing: Covered by existing WPT.

@jdm
Copy link
Member Author
jdm commented Aug 9, 2025

@sagudev
Copy link
Member
sagudev commented Aug 10, 2025

OK /webaudio/the-audio-api/the-delaynode-interface/delay-test.html

FAIL [expected PASS] subtest: X Setting delayTime to 3 frames incorrectly threw TypeError: "can't access property "delayTime", delay is undefined".

It's probably flake.

@jdm
Copy link
Member Author
jdm commented Aug 10, 2025

OK /webaudio/the-audio-api/the-delaynode-interface/delay-test.html
FAIL [expected PASS] subtest: X Setting delayTime to 3 frames incorrectly threw TypeError: "can't access property "delayTime", delay is undefined".

It's probably flake.

Nope :). SpiderMonkey provides a better error now.

@jdm
Copy link
Member Author
jdm commented Aug 20, 2025

Ignoring the cargo override in the first commit, this should now be ready for the final review.

@jdm jdm marked this pull request as ready for review August 20, 2025 04:56
@jdm jdm requested a review from gterzian as a code owner August 20, 2025 04:56
jdm added 4 commits August 20, 2025 03:03
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
@jdm jdm added this pull request to the merge queue Aug 20, 2025
Merged via the queue into servo:main with commit 604b6ea Aug 20, 2025
22 checks passed
@jdm jdm deleted the 140up branch August 20, 2025 08:27
github-merge-queue bot pushed a commit that referenced this pull request Aug 20, 2025
Update user agent strings to match Firefox 140 now that #38563 is
merged.

Testing: No tests for user agent string update.

Signed-off-by: Alex Touchet <26315797+atouchet@users.noreply.github.com>
PotatoCP added a commit to PotatoCP/servo that referenced this pull request Aug 21, 2025
{"fail_fast": false, "matrix": [{"name": "Linux (WPT)", "workflow": "linux", "wpt": true, "profile": "release", "unit_tests": false, "build_libservo": false, "bencher": false, "build_args": "", "wpt_args": "./tests/wpt/tests/webdriver/tests/classic/ --product servodriver --headless --processes 1", "number_of_wpt_chunks": 2}]}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0