10BC0 devtools: Expose `introductionType` to devtools clients by delan · Pull Request #38541 · servo/servo · GitHub
[go: up one dir, main page]

Skip to content

Conversation

delan
Copy link
Member
@delan delan commented Aug 8, 2025

in the devtools protocol, source forms announced in resources-available-array messages can include the introductionType, which more or less mirrors the field of the same name in SpiderMonkey’s CompileOptions.

this patch exposes introductionType accordingly, allowing us to check for the correct values in automated tests.

Testing: new coverage in devtools tests
Fixes: part of #36027

@delan delan requested a review from atbrakhi August 8, 2025 09:54
@delan delan requested a review from gterzian as a code owner August 8, 2025 09:54
Co-authored-by: atbrakhi <atbrakhi@igalia.com>
Signed-off-by: Delan Azabani <dazabani@igalia.com>
@delan delan force-pushed the expose-introductionType-to-devtools branch from 62daa44 to f62ca3c Compare August 8, 2025 09:57
@atbrakhi atbrakhi enabled auto-merge August 8, 2025 10:03
@atbrakhi atbrakhi added this pull request to the merge queue Aug 8, 2025
delan added a commit that referenced this pull request Aug 8, 2025
Co-authored-by: atbrakhi <atbrakhi@igalia.com>
Signed-off-by: Delan Azabani <dazabani@igalia.com>
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 8, 2025
@delan delan enabled auto-merge August 8, 2025 11:09
Signed-off-by: Delan Azabani <dazabani@igalia.com>
@delan delan force-pushed the expose-introductionType-to-devtools branch from e12517a to 96cf74e Compare August 8, 2025 12:07
@delan delan added this pull request to the merge queue Aug 8, 2025
delan added a commit that referenced this pull request Aug 8, 2025
Co-authored-by: atbrakhi <atbrakhi@igalia.com>
Signed-off-by: Delan Azabani <dazabani@igalia.com>
delan added a commit that referenced this pull request Aug 8, 2025
Co-authored-by: atbrakhi <atbrakhi@igalia.com>
Signed-off-by: Delan Azabani <dazabani@igalia.com>
Merged via the queue into main with commit c9541f2 Aug 8, 2025
21 checks passed
@delan delan deleted the expose-introductionType-to-devtools branch August 8, 2025 13:26
@delan delan mentioned this pull request Aug 7, 2025
81 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0