script: Ensure notify_invalidations() is always called when modifying stylesheets
#38530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔨 Triggering try run (#16824714233) for Linux (WPT) |
|
Test results for linux-wpt from try job (#16824714233): Flaky unexpected result (19)
Stable unexpected results that are known to be intermittent (25)
Stable unexpected results (1)
|
|
|
c7d5dc3 to
763fa74
Compare
xiaochengh
reviewed
Aug 11, 2025
components/script/dom/medialist.rs
Outdated
|
|
||
| /// <https://drafts.csswg.org/cssom/#dom-medialist-mediatext> | ||
| fn SetMediaText(&self, value: DOMString) { | ||
| let _rules_modification_scope = RulesModificationScope::new(&self.parent_stylesheet); |
There was a problem hiding this comment.
Does this really work? I thought in Rust you can't control when an object is released, which is fully determined by the compiler...
|
All works in this PR have been moved into another PR: #38540 |
Because everyone was discussing it on another PR, I simply closed this PR. Indeed, this PR can be independent. |
Signed-off-by: sharpshooter_pt <ibluegalaxy_taoj@163.com>
763fa74 to
3a077bb
Compare
mrobinson
approved these changes
Aug 15, 2025
notify_invalidations() is always called when modifying stylesheets
PotatoCP
pushed a commit
to PotatoCP/servo
that referenced
this pull request
Aug 20, 2025
…ng stylesheets (servo#38530) This change supplements the missing stylesheet invalidation notifications to fix some bugs that the modification of stylesheet does not take effect. Additionally, this PR add a RAII thing to mark the modification scope of stylesheet rules, which will facilitate to add extra logic before the modification happens. Fixes: there is relevant issue servo#38211 , but it can't be fixed by this PR. Testing: This fixes some subtests in `/css/cssom/CSSStyleSheet-constructable.html`. Signed-off-by: sharpshooter_pt <ibluegalaxy_taoj@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change supplements the missing stylesheet invalidation notifications to fix some bugs that the modification of stylesheet does not take effect. Additionally, this PR add a RAII thing to mark the modification scope of stylesheet rules, which will facilitate to add extra logic before the modification happens.
Fixes: there is relevant issue #38211 , but it can't be fixed by this PR.
Testing: This fixes some subtests in
/css/cssom/CSSStyleSheet-constructable.html.