8000 mach: Allow filtering tests in `mach test-devtools` by delan · Pull Request #38514 · servo/servo · GitHub
[go: up one dir, main page]
Skip to content

mach: Allow filtering tests in mach test-devtools #38514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 7, 2025
Merged

mach: Allow filtering tests in mach test-devtools #38514

merged 2 commits into from
Aug 7, 2025

Conversation

delan
Copy link
Member

@delan delan commented Aug 7, 2025 •
edited
Loading

mach test-devtools uses unittest without unittest.main(), so we can parse arguments and set up the test runner how we want, but this means there’s currently no way to filter tests on the command line.

this patch plumbs the positional arguments (if any) into the TestLoader’s testNamePatterns, with extra logic to treat any pattern pattern not containing * like *pattern*. this is the same behaviour as unittest.main() -k:

$ ./mach test-devtools domparser responsexml
Running devtools tests...
Running 2 tests:
- test_source_content_inline_script_with_domparser (servo.devtools_tests.DevtoolsTests.test_source_content_inline_script_with_domparser)
- test_source_content_inline_script_with_responsexml (servo.devtools_tests.DevtoolsTests.test_source_content_inline_script_with_responsexml)

test_source_content_inline_script_with_domparser (servo.devtools_tests.DevtoolsTests.test_source_content_inline_script_with_domparser) ... ok
test_source_content_inline_script_with_responsexml (servo.devtools_tests.DevtoolsTests.test_source_content_inline_script_with_responsexml) ... ok

----------------------------------------------------------------------
Ran 2 tests in 4.055s

OK

Testing: not really worth automated testing, but tested manually above
Fixes: part of #36325

@delan
mach: Allow filtering tests in mach test-devtools
191626c 
Signed-off-by: Delan Azabani <dazabani@igalia.com>
@delan delan requested a review from atbrakhi August 7, 2025 10:16
@delan delan mentioned this pull request Jul 30, 2025
Closed
7 tasks
@delan
Handle patterns not containing * like unittest.main() -k
20fd24e 
Signed-off-by: Delan Azabani <dazabani@igalia.com>
delan added a commit that referenced this pull request Aug 7, 2025
@delan
mach: Allow filtering tests in mach test-devtools (#38514)
6a6f207 
Signed-off-by: Delan Azabani <dazabani@igalia.com>
@delan delan added this pull request to the merge queue Aug 7, 2025
Merged via the queue into main with commit 8cfd82f Aug 7, 2025
22 checks passed
@delan delan deleted the mach-test-devtools-filter branch August 7, 2025 13:50
@delan delan mentioned this pull request Aug 7, 2025
Open
81 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm jdm approved these changes

@atbrakhi atbrakhi Awaiting requested review from atbrakhi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@delan @jdm
0