webdriver: Check if container is obscured for "Element Click" #38497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Euclid Ye <euclid.ye@huawei.com>
Signed-off-by: Euclid Ye <euclid.ye@huawei.com>
yezhizhen
commented
Aug 6, 2025
There was a problem hiding this comment.
The new fail test is plausible and exposes new problems.
- We correctly report "obscured" at added step 7.
- We correctly compute paint tree..for a wrongly rendered
select😅
What Firefox looks like:
What servo looks like:
yezhizhen
commented
Aug 6, 2025
xiaochengh
approved these changes
Aug 7, 2025
This was referenced Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement step 7 of Element Click: check whether container is obscured.
Testing:
/webdriver/tests/classic/element_click/interactability.pycan now fully pass. Other changes are combined effect with 17a269a due to script execution, and exposes new problem: #38497 (comment)