E539 canvas: Use OptimizeSpeed in vello_cpu by sagudev · Pull Request #38437 · servo/servo · GitHub
[go: up one dir, main page]
Skip to content

canvas: Use OptimizeSpeed in vello_cpu #38437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 3, 2025
Merged

canvas: Use OptimizeSpeed in vello_cpu #38437

merged 2 commits into from
Aug 3, 2025

Conversation

sagudev
Copy link
Member
@sagudev sagudev commented Aug 3, 2025

According to my tests OptimizeSpeed slight improves performance and it does NOT affect WPT results in negative way.

Testing: Tested by existing WPT tests.

sagudev added 2 commits August 3, 2025 10:27
@sagudev
canvas: Use OptimizeSpeed in vello_cpu
106d28d 
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
@sagudev
Update expectations
c9eb39e 
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
@sagudev sagudev requested a review from nicoburns August 3, 2025 10:06
nicoburns
nicoburns approved these changes Aug 3, 2025
View reviewed changes
Copy link
Contributor
@nicoburns nicoburns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is correct:

  • OptimiseSpeed = u8 subpixels (regular RGB8).
  • OptimiseQuality = f32 subpixels (mostly useful for HDR)

@nicoburns nicoburns added this pull request to the merge queue Aug 3, 2025
@sagudev
Copy link
Member Author
sagudev commented Aug 3, 2025

I think this is correct:

* `OptimiseSpeed` = u8 subpixels (regular RGB8).

* `OptimiseQuality` = f32 subpixels (mostly useful for HDR)

We should add this to vello docs.

Merged via the queue into servo:main with commit fe9341d Aug 3, 2025
21 checks passed
@sagudev sagudev self-assigned this Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoburns nicoburns nicoburns approved these changes

Assignees

@sagudev sagudev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sagudev @nicoburns
0