layout: Account for sticky nodes in ScrollTree transforms and cache transforms #38391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loirooriol
approved these changes
Jul 31, 2025
Comment on lines
419
to
420
| SpatialTreeNodeInfo::Scroll(info) if info.offset_changed.get() => { | ||
| info.offset_changed.set(false); |
There was a problem hiding this comment.
Maybe simpler with take()
Suggested change
| SpatialTreeNodeInfo::Scroll(info) if info.offset_changed.get() => { | |
| info.offset_changed.set(false); | |
| SpatialTreeNodeInfo::Scroll(info) if info.offset_changed.take() => { |
…ransforms When calculating the node to world transform for use in bounding box queries, cache the values of the transform. In addition, when scroll offsets change, ensure that the cached values are invalided properly. This change necessitated the storage of children for each node in the tree, so that we can walk both up and down the tree. The purpose of this part of the change is to increase performance when doing multiple queries and prepare the tree for hit testing. In addition, this change also tries to take into account sticky offsets, using the algorithm from WebRender to calculate sticky offsets. This is also going to be important for hit testing. Signed-off-by: Martin Robinson <mrobinson@igalia.com> Co-authored-by: Oriol Brufau <obrufau@igalia.com>
3e5cd3a to
b18f5a1
Compare
minghuaw
pushed a commit
to minghuaw/servo
that referenced
this pull request
Aug 1, 2025
…ransforms (servo#38391) When calculating the node to world transform for use in bounding box queries, cache the values of the transform. In addition, when scroll offsets change, ensure that the cached values are invalided properly. This change necessitated the storage of children for each node in the tree, so that we can walk both up and down the tree. The purpose of this part of the change is to increase performance when doing multiple queries and prepare the tree for hit testing. In addition, this change also tries to take into account sticky offsets, using the algorithm from WebRender to calculate sticky offsets. This is also going to be important for hit testing. Testing: Newly passing tests: - /css/css-position/position-sticky-dynamic-ancestor-001.html - /css/css-tables/tentative/position-sticky-container.html Signed-off-by: Martin Robinson <mrobinson@igalia.com> Co-authored-by: Oriol Brufau <obrufau@igalia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calculating the node to world transform for use in bounding box
queries, cache the values of the transform. In addition, when scroll
offsets change, ensure that the cached values are invalided properly.
This change necessitated the storage of children for each node in the
tree, so that we can walk both up and down the tree. The purpose of this
part of the change is to increase performance when doing multiple
queries and prepare the tree for hit testing.
In addition, this change also tries to take into account sticky offsets,
using the algorithm from WebRender to calculate sticky offsets. This is
also going to be important for hit testing.
Testing: Newly passing tests: