layout: Include spanned gutters when laying out contents of table cell #38290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔨 Triggering try run (#16540369675) for Linux (WPT) |
|
Test results for linux-wpt from try job (#16540369675): Flaky unexpected result (13)
Stable unexpected results that are known to be intermittent (23)
|
|
✨ Try run (#16540369675) succeeded. |
If a cell would e.g. span 2 columns, each 50px wide, separated by a 10px gutter, then we used to lay out the contents of the cell with a 100px wide containing block. Now we will include the size of the gutter. Signed-off-by: Oriol Brufau <obrufau@igalia.com>
d28fab1 to
7b751ef
Compare
|
🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#53996) with upstreamable changes. |
|
✍ Updated existing upstream WPT pull request (web-platform-tests/wpt#53996) title and body. |
mrobinson
approved these changes
Jul 29, 2025
uthmaniv
pushed a commit
to uthmaniv/servo
that referenced
this pull request
Jul 29, 2025
servo#38290) If a cell would e.g. span 2 columns, each 50px wide, separated by a 10px gutter, then we used to lay out the contents of the cell with a 100px wide containing block. Now we will include the size of the gutter. Testing: Adding new test Fixes: servo#38277 Signed-off-by: Oriol Brufau <obrufau@igalia.com>
minghuaw
pushed a commit
to minghuaw/servo
that referenced
this pull request
Aug 1, 2025
servo#38290) If a cell would e.g. span 2 columns, each 50px wide, separated by a 10px gutter, then we used to lay out the contents of the cell with a 100px wide containing block. Now we will include the size of the gutter. Testing: Adding new test Fixes: servo#38277 Signed-off-by: Oriol Brufau <obrufau@igalia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a cell would e.g. span 2 columns, each 50px wide, separated by a 10px gutter, then we used to lay out the contents of the cell with a 100px wide containing block. Now we will include the size of the gutter.
Testing: Adding new test
Fixes: #38277