Rework on webdriver wait for navigation complete #38234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d9b14fc to
9744cb1
Compare
xiaochengh
reviewed
Jul 24, 2025
tests/wpt/meta/webdriver/tests/classic/get_element_css_value/user_prompts.py.ini
Outdated
Show resolved
Hide resolved
9744cb1 to
53bbfbf
Compare
xiaochengh
reviewed
Jul 25, 2025
There was a problem hiding this comment.
After thinking more about navigation to fragment, I'm not sure if waiting for dom events is the right approach. It feels like a hacky heuristic to me. And I'm not even sure if we should wait for those if events if the navigation triggers any.
At a lower level, in the current solution, we are adding tasks that are not dom manipulations to the dom manipulation task source. And it's hard to infer when exactly this will be complete.
Is there a more idiomatic solution where we can identify the completion of a navigation to fragment, and send the completion event from there?
d3cced3 to
1fd7cf1
Compare
xiaochengh
reviewed
Jul 28, 2025
0459399 to
e8e595d
Compare
Signed-off-by: batu_hoang <hoang.binh.trong@huawei.com>
Signed-off-by: batu_hoang <hoang.binh.trong@huawei.com>
e8e595d to
2a1eb39
Compare
xiaochengh
approved these changes
Jul 30, 2025
minghuaw
pushed a commit
to minghuaw/servo
that referenced
this pull request
Aug 1, 2025
For current implementation, when a command may trigger a navigation, webdriver only waits for document readiness state. However, not all navigations make change in document. This PR handles more cases for waiting for a navigation, and apply to `element_click`. - Before sending a command which may trigger a navigation, `webdriver` sets `load status send` to `embedder`, `constelltation` and `script thread` to listen to `navigation events`. - Webdriver check if there is a navigation with `script thread`. - If the navigation is loading a new url, webdriver checks if the request is approved with `constellation`, then waits for document readiness state. - If the navigation is a hashchange, webdriver waits untill all new generated dom events have been processed. Testing: `tests/wpt/tests/webdriver/tests/classic/element_click/navigate.py` `tests/wpt/tests/webdriver/tests/classic/element_click/user_prompts.py` https://github.com/longvatrong111/servo/actions/runs/16488690749 cc: @xiaochengh --------- Signed-off-by: batu_hoang <hoang.binh.trong@huawei.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For current implementation, when a command may trigger a navigation, webdriver only waits for document readiness state.
However, not all navigations make change in document.
This PR handles more cases for waiting for a navigation, and apply to
element_click.webdriversetsload status sendtoembedder,constelltationandscript threadto listen tonavigation events.script thread.constellation, then waits for document readiness state.Testing:
tests/wpt/tests/webdriver/tests/classic/element_click/navigate.pytests/wpt/tests/webdriver/tests/classic/element_click/user_prompts.pyhttps://github.com/longvatrong111/servo/actions/runs/16488690749
cc: @xiaochengh