doc: Add doc for compositor/webview/embedder related to window/rect/inner_size/rendering_context #38110
Conversation
| fn winit_window(&self) -> Option<&winit::window::Window>; | ||
| fn toolbar_height(&self) -> Length<f32, DeviceIndependentPixel>; | ||
| fn set_toolbar_height(&self, height: Length<f32, DeviceIndependentPixel>); | ||
| /// Viewport. |
There was a problem hiding this comment.
Is this intended? The description doesn't match the method either.
There was a problem hiding this comment.
Sorry for that. Just made it more concrete!
There was a problem hiding this comment.
hmm a rendering context is more that just a viewport I think. It should linkt to this trait.
There was a problem hiding this comment.
Yes. But everytime we call
people seem to use it as viewport size.
There was a problem hiding this comment.
For example
servo/ports/servoshell/output_image.rs
Lines 27 to 28 in cbdf72b
There was a problem hiding this comment.
How can we add better doc for fn rendering_context? I think I understand your concern.
Right now I'm going with
/// This returns [RenderingContext] matching the viewport.
Signed-off-by: Euclid Ye <euclid.ye@huawei.com>
|
Can someone check this? It is very important for next step fix. I want to ensure correctness. |
…nner_size/rendering_context (servo#38110) Add docs before actually fixing servo#38089, servo#38090, servo#37978, servo#38093. Testing: Just adding docs. --------- Signed-off-by: Euclid Ye <euclid.ye@huawei.com>
Add docs before actually fixing #38089, #38090, #37978, #38093.
Testing: Just adding docs.