Add Linux .desktop file #38038
Add Linux .desktop file #38038
Conversation
I'm trying to use Servo as a daily driver. I like to pin the most often used apps to the my taskbar (Dash to Panel in Gnome). I also launch apps from the menu (Arc Menu). Adding a .desktop file make it show up in the menu. I could not get pinning to work until I set the name with `winit`. This is because the name is used to match it with the icon. I used the Gnome Looking Glass (lg) command to determine that the name was not set. Testing: I followed the instructions that I put in the .desktop file. I copied the .desktop file to the right folder, set up a link to the svg icon, and adjusted the paths to point to the compiled executable. Signed-off-by: Michael Mc Donnell <michael@mcdonnell.dk>
Two issue came up during the review. I had forgotten to gate the change for Linux. The other was import the Wayland window attributes or the X11 attributes. They both call the exact same code but I think importing the Wayland version might be better since X11 is being deprecated by several distributions. Signed-off-by: Michael Mc Donnell <michael@mcdonnell.dk>
|
lgtm, thanks! |
Thank you for the review! |
|
Thanks for merging @jdm! |
{"fail_fast": false, "matrix": [{"name": "Linux (WPT)", "workflow": "linux", "wpt": true, "profile": "release", "unit_tests": false, "build_libservo": false, "bencher": false, "build_args": "", "wpt_args": "./tests/wpt/tests/webdriver/tests/classic/ --product servodriver --headless", "number_of_wpt_chunks": 1}]}
{"fail_fast": false, "matrix": [{"name": "Linux (WPT)", "workflow": "linux", "wpt": true, "profile": "release", "unit_tests": false, "build_libservo": false, "bencher": false, "build_args": "", "wpt_args": "./tests/wpt/tests/webdriver/tests/classic/ --product servodriver --headless", "number_of_wpt_chunks": 1}]}
{"fail_fast": false, "matrix": [{"name": "Linux (WPT)", "workflow": "linux", "wpt": true, "profile": "release", "unit_tests": false, "build_libservo": false, "bencher": false, "build_args": "", "wpt_args": "./tests/wpt/tests/webdriver/tests/classic/ --product servodriver --headless", "number_of_wpt_chunks": 1}]}
|
Usually |
I can understand why it seems odd. This is not intended for shipping to end users yet. This is focused on improving the developer experience and not the end user experience as a start. I am challenging myself to use Servo more and this makes it easier for me to start Servo. I thought it would be better to have this in the repository for other developers to use instead of me keeping it to myself. It was also a good manual test that showed we need to set the name and wmclass on Linux. We could add a Does that make more sense? Do you have any suggestions? |
I'm trying to use Servo as a daily driver. I like to pin the most often used apps to the my taskbar (Dash to Panel in Gnome). I also launch apps from the menu (Arc Menu). Adding a .desktop file make it show up in the menu. I could not get pinning to work until I set the name with
winit. This is because the name is used to match it with the icon. I used the Gnome Looking Glass (lg) command to determine that the name was not set.Testing: I followed the instructions that I put in the .desktop file. I copied the .desktop file to the right folder, set up a link to the svg icon, and adjusted the paths to point to the compiled executable.