8000 Webdriver: Send Keys use `webview::notify_input_event` by PotatoCP · Pull Request #37911 · servo/servo · GitHub
[go: up one dir, main page]
Skip to content

Webdriver: Send Keys use webview::notify_input_event #37911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 10, 2025
Merged

Webdriver: Send Keys use webview::notify_input_event #37911

merged 2 commits into from
Jul 10, 2025

Conversation

PotatoCP
Copy link
Contributor
@PotatoCP PotatoCP commented Jul 7, 2025 •
edited
Loading

Previously, we SendKeys will be forwarded to constellation by the embedder. Now we use webview.notify_input_event, which will send WebDriverCommandMsg::ForwardInputEvent for the KeyboardEvent and CompositionEvent.

Fixes: part of #37370

@PotatoCP
Copy link
Contributor Author
PotatoCP commented Jul 7, 2025

Try: https://github.com/PotatoCP/servo/actions/runs/16108638821
cc: @xiaochengh @longvatrong111 @yezhizhen

@PotatoCP PotatoCP changed the title Webdriver: Send Keys use webview::notify_input_event Webdriver: Send Keys use webview::notify_input_event Jul 7, 2025
@PotatoCP PotatoCP marked this pull request as ready for review July 7, 2025 05:49
@PotatoCP PotatoCP requested a review from atbrakhi as a code owner July 7, 2025 05:49
@xiaochengh xiaochengh self-requested a review July 7, 2025 10:39
jdm
jdm approved these changes Jul 8, 2025
View reviewed changes
Copy link
Member
@jdm jdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love how much simpler this is.

@PotatoCP
Send Keys use webview::notify_input_event
e29dc5d 
Signed-off-by: PotatoCP <kenzieradityatirtarahardja18@gmail.com>
@PotatoCP
Copy link
Contributor Author

I have just rebased to resolve conflict

@PotatoCP @mrobinson
make build great again after rebase
184ad4c 
Signed-off-by: PotatoCP <kenzieradityatirtarahardja18@gmail.com>
mrobinson
mrobinson reviewed Jul 10, 2025
View reviewed changes
Copy link
Member
@mrobinson mrobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a small adjustment to not continually fetch the WebView while processing events.

@mrobinson mrobinson enabled auto-merge July 10, 2025 12:03
@mrobinson mrobinson added this pull request to the merge queue Jul 10, 2025
Merged via the queue into servo:main with commit a475175 Jul 10, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrobinson mrobinson mrobinson left review comments

@jdm jdm jdm approved these changes

@atbrakhi atbrakhi Awaiting requested review from atbrakhi atbrakhi is a code owner

@xiaochengh xiaochengh Awaiting requested review from xiaochengh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PotatoCP @mrobinson @jdm
0