webdriver: enable getting closed shadow root #37826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: PotatoCP <kenzieradityatirtarahardja18@gmail.com>
yezhizhen
approved these changes
Jul 2, 2025
xiaochengh
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when getting element shadow root, we are using GetShadowRoot. This is a getter which only allows javascript to access shadow root with
openmode.In webdriver spec, particularly step 5, it seems that they imply for us to get the shadow root without going through the above getter.
P.S. Other browser seems to also allows getting closed shadow root, like Chromium here: https://chromium-review.googlesource.com/c/chromium/src/+/5923865.
Testing: Covered in webdriver WPT test that access closed shadow root.