Move webdriver actions commands to servoshell #37669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
59970d4 to
254fea5
Compare
|
🛠 These changes could not be applied onto the latest upstream WPT. Servo's copy of the Web Platform Tests may be out of sync. |
254fea5 to
41bcf67
Compare
This was referenced Jun 25, 2025
Merged
xiaochengh
reviewed
Jun 25, 2025
41bcf67 to
a498bb1
Compare
a498bb1 to
09fbd23
Compare
PotatoCP
reviewed
Jun 26, 2025
mrobinson
requested changes
Jun 26, 2025
09fbd23 to
3d39028
Compare
xiaochengh
approved these changes
Jun 27, 2025
PotatoCP
reviewed
Jun 30, 2025
3d39028 to
5712277
Compare
PotatoCP
reviewed
Jul 4, 2025
PotatoCP
reviewed
Jul 4, 2025
Signed-off-by: batu_hoang <longvatrong111@gmail.com>
5712277 to
15b31b4
Compare
|
@mrobinson I made some updates, can you kindly review this again? |
mrobinson
approved these changes
Jul 4, 2025
Comment on lines
+457
to
+463
| // Key events don't need hit test so can be forwarded to constellation for now | ||
| WebDriverCommandMsg::SendKeys(..) => { | ||
| running_state.forward_webdriver_command(msg); | ||
| }, | ||
| WebDriverCommandMsg::KeyboardAction(..) => { | ||
| running_state.forward_webdriver_command(msg); | ||
| }, |
There was a problem hiding this comment.
Eventually these should use notify_input_event. That would be good to do in a followup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move webdriver actions commands to servoshell.
Testing: Test with webdriver enable in the CI
Test result 1
Test result 2
Test result 3
Fixes: #37370