8000 DevTools: Add `resource_available` as a common shared util by atbrakhi · Pull Request #36632 · servo/servo · GitHub
[go: up one dir, main page]

Skip to content

Conversation

atbrakhi
Copy link
Member
@atbrakhi atbrakhi commented Apr 21, 2025

These PR adds resource_available as a common shared util

@atbrakhi atbrakhi requested a review from gterzian as a code owner April 21, 2025 15:23
@atbrakhi atbrakhi requested a review from mrobinson April 21, 2025 15:24
@atbrakhi atbrakhi changed the title DevTools: Add resource_available for worker scripts DevTools: Add resource_available as common shared util Apr 23, 2025
@atbrakhi atbrakhi changed the title DevTools: Add resource_available as common shared util DevTools: Add resource_available as s common shared util Apr 23, 2025
@atbrakhi atbrakhi requested a review from jdm April 23, 2025 09:24
@atbrakhi atbrakhi changed the title DevTools: Add resource_available as s common shared util DevTools: Add resource_available as a common shared util Apr 23, 2025
Signed-off-by: atbrakhi <atbrakhi@igalia.com>
Copy link
Member
@jdm jdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

use crate::protocol::JsonPacketStream;

#[derive(Serialize)]
pub struct ResourceAvailableReply<T: Serialize> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pub struct ResourceAvailableReply<T: Serialize> {
pub(crate) struct ResourceAvailableReply<T: Serialize> {

Signed-off-by: atbrakhi <atbrakhi@igalia.com>
@atbrakhi atbrakhi mentioned this pull request Apr 17, 2025
81 tasks
@atbrakhi atbrakhi enabled auto-merge April 23, 2025 12:09
@atbrakhi atbrakhi added this pull request to the merge queue Apr 23, 2025
Merged via the queue into servo:main with commit 7c1e591 Apr 23, 2025
21 checks passed
@atbrakhi atbrakhi deleted the worker_script branch April 23, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0