8000 devtools: improve `ID` naming for better readability and context by atbrakhi · Pull Request #35942 · servo/servo · GitHub
[go: up one dir, main page]
Skip to content

devtools: improve ID naming for better readability and context #35942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2025
Merged

devtools: improve ID naming for better readability and context #35942

merged 1 commit into from
Mar 13, 2025

Conversation

atbrakhi
Copy link
Member

Renamed various IDs such as stream_id, pipeline_id browsing_context_it for better readability and context

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #___ (GitHub issue number if applicable)

@atbrakhi
devtools: improve ID Naming for better readability and context
b22809d 
Signed-off-by: atbrakhi <atbrakhi@igalia.com>
@atbrakhi atbrakhi marked this pull request as ready for review March 13, 2025 07:36
@atbrakhi atbrakhi added this pull request to the merge queue Mar 13, 2025
Merged via the queue into servo:main with commit eb2ca42 Mar 13, 2025
22 checks passed
@atbrakhi atbrakhi deleted the devtools_refactor_id_naming branch March 13, 2025 08:24
@delan delan mentioned this pull request Jul 28, 2025
Open
81 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrobinson mrobinson mrobinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atbrakhi @mrobinson
0