mozjs_sys: Honor the CXXSTDLIB environment variable
#615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagudev
reviewed
Aug 18, 2025
Comment on lines
394
to
398
| } else if target.contains("windows") && target.contains("gnu") { | ||
| println!("cargo:rustc-link-lib=stdc++"); | ||
| } else { | ||
| println!("cargo:rustc-link-lib=stdc++") | ||
| } |
There was a problem hiding this comment.
This is not equivalent to previous code in case we are on windows without gnu.
Suggested change
| } else if target.contains("windows") && target.contains("gnu") { | |
| println!("cargo:rustc-link-lib=stdc++"); | |
| } else { | |
| println!("cargo:rustc-link-lib=stdc++") | |
| } | |
| } else if target.contains("windows") && target.contains("gnu") { | |
| println!("cargo:rustc-link-lib=stdc++"); | |
| } else if !target.contains("windows") { | |
| println!("cargo:rustc-link-lib=stdc++") | |
| } |
|
Also this change requires mozjs_sys version bump: |
In the same commit, or a separate one? |
It doesn't matter because all PRs are squashed on landing. |
`CXXSTDLIB` is an environment variable used by `cc` and many other crates which lets developers to choose a standard C++ library of their choice. Make use of that variable in mozjs_sys's build.rs as well. One of the use cases is supporting Linux distributions which use LLVM instead of GCC as the main toolchain (e.g. Chimera, Gentoo musl-llvm profile, OpenMandriva). Signed-off-by: Michal Rostecki <vadorovsky@disroot.org>
OK, done |
sagudev
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CXXSTDLIBis an environment variable used byccand many other crates which lets developers to choose a standard C++ library of their choice.Make use of that variable in mozjs_sys's build.rs as well.
One of the use cases is supporting Linux distributions which use LLVM instead of GCC as the main toolchain (e.g. Chimera, Gentoo musl-llvm profile, OpenMandriva).