8000 CloudFront Support by danielcondemarin · Pull Request #95 · serverless-nextjs/serverless-next.js · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Jan 28, 2025. It is now read-only.

CloudFront Support #95

Merged
merged 7 commits into from
Jun 30, 2019
Merged

CloudFront Support #95

merged 7 commits into from
Jun 30, 2019

Conversation

danielcondemarin
Copy link
Contributor
@danielcondemarin danielcondemarin commented Jun 29, 2019 •
edited
Loading

CloudFront Support

Motivation

Currently, API Gateway is being used as a proxy to S3 to serve static assets from /static and /public directories. Whilst this works, is not the best solution as API Gateway is not as cost effective as CloudFront, nor is designed to be used as a CDN.
Also CloudFront comes with features such as compression, logging, domains, certificates etc.

Proposal

custom:
  serverless-nextjs:
    assetsBucketName: cloudfront.isawesome
    cloudFront: true

When cloudFront flag is set to true, a CloudFront distribution is created with API Gateway and S3 as origins. _next build assets and static/ or public/ folder assets are served from the S3 origin. Page requests, such as /blog/:post are served from the API Gateway origin.

This article was used as a reference for implementation:
https://aws.amazon.com/premiumsupport/knowledge-center/api-gateway-cloudfront-distribution/

@danielcondemarin danielcondemarin mentioned this pull request Jun 29, 2019
Closed
@danielcondemarin danielcondemarin marked this pull request as ready for review June 30, 2019 18:29
@danielcondemarin danielcondemarin merged commit d57756e into master Jun 30, 2019
@danielcondemarin danielcondemarin deleted the CloudFront-support branch June 30, 2019 18:31
@ulysset
Copy link
ulysset commented Jul 1, 2019

Hey @danielcondemarin !
I don't understand if we need both the assetsBucketName and the assetPrefix or only the assetsBucketName. If we need the assetPrefix what should we put? something like "my-bucket-name.cloudfront.net"?

@danielcondemarin
Copy link
Contributor Author

@ulysset If you are using cloudfront you only need assetsBucketName. Next build asset (/_next/*) requests are handled by the cloudfront distribution so you don’t really need the assetPrefix in that case.

@ulysset
Copy link
ulysset commented Jul 5, 2019

Ok thank you!
To use a custom domain so the next step is to manually go into CloudFront -> General -> Edit -> Edit custom SSL Certificate or CNAME?

@danielcondemarin
Copy link
Contributor Author

@ulysset Manually updating the distribution is a bad idea as it will drift the stack.
Instead you can now override the default cloud front configuration, available in v2.2.0-alpha.0. Check https://github.com/danielcondemarin/serverless-nextjs-plugin#serving-static-assets for more details

@barrysteyn barrysteyn mentioned this pull request Sep 1, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielcondemarin @ulysset
0