8000 Create 1.x branch by Jean-Beru · Pull Request #153 · sensiolabs/GotenbergBundle · GitHub
[go: up one dir, main page]
Skip to content

Create 1.x branch #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 69 commits into from
Jun 11, 2025
Merged

Create 1.x branch #153

merged 69 commits into from
Jun 11, 2025

Conversation

Jean-Beru
Copy link
Contributor
@Jean-Beru Jean-Beru commented Apr 10, 2025 •
edited
Loading
Q A
Gotenberg API version ? 8.x
Bug fix ? no
New feature ? no
BC break ? maybe
Issues

Description

Too much things to say

Todo

@Jean-Beru Jean-Beru added the enhancement New feature or request label Apr 10, 2025
@Jean-Beru Jean-Beru changed the title 1.x Create 1.x branch Apr 10, 2025
@Jean-Beru Jean-Beru force-pushed the 1.x branch 4 times, most recently from 48758c1 to 6387699 Compare April 11, 2025 07:10
Neirda24
Neirda24 reviewed Apr 11, 2025
View reviewed changes
Neirda24
Neirda24 reviewed Apr 11, 2025
View reviewed changes
Neirda24
Neirda24 reviewed Apr 12, 2025
View reviewed changes
Neirda24
Neirda24 reviewed Apr 12, 2025
View reviewed changes
Neirda24
Neirda24 reviewed Apr 12, 2025
View reviewed changes
Neirda24
Neirda24 reviewed Apr 12, 2025
View reviewed changes
@Jean-Beru Jean-Beru mentioned this pull request Apr 14, 2025
Merged
Neirda24
Neirda24 reviewed Apr 15, 2025
View reviewed changes
@StevenRenaux
Copy link
Collaborator
StevenRenaux commented Apr 28, 2025 •
edited
Loading

Wait symfony/symfony#60268 to be merged to remove:

/**
 * @method Environment getTwig()
 */
 
 /**
 * @method UrlGeneratorInterface getUrlGenerator()
 */

And the |null on the return type from UrlGeneratorAwareTrait and TwigAwareTrait

@Neirda24 Neirda24 marked this pull request as ready for review June 4, 2025 06:36
@Jean-Beru Jean-Beru merged commit 669166a into sensiolabs:1.x Jun 11, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neirda24 Neirda24 Neirda24 left review comments

@StevenRenaux StevenRenaux StevenRenaux left review comments

Assignees

@Jean-Beru Jean-Beru

@Neirda24 Neirda24

@StevenRenaux StevenRenaux

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jean-Beru @StevenRenaux @Neirda24
0