10000 fix: Revert "fix: failing release due to renamed repository (#878)" by gr2m · Pull Request #887 · semantic-release/github · GitHub
[go: up one dir, main page]
Skip to content

fix: Revert "fix: failing release due to renamed repository (#878)" #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and th 10000 e community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2024
Merged

fix: Revert "fix: failing release due to renamed repository (#878)" #887

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions lib/definitions/errors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,17 +139,6 @@ By default the \`repositoryUrl\` option is retrieved from the \`repository\` pro
};
}

export function EMISMATCHGITHUBURL() {
return {
message: "The git repository URL mismatches the GitHub URL.",
details: `The **semantic-release** \`repositoryUrl\` option must match your GitHub URL with the format \`<GitHub_or_GHE_URL>/<owner>/<repo>.git\`.

By default the \`repositoryUrl\` option is retrieved from the \`repository\` property of your \`package.json\` or the [git origin url](https://git-scm.com/book/en/v2/Git-Basics-Working-with-Remotes) of the repository cloned by your CI environment.

Note: If you have recently changed your GitHub repository name or owner, update the value in **semantic-release** \`repositoryUrl\` option and the \`repository\` property of your \`package.json\` respectively to match the new GitHub URL.`,
};
}

export function EINVALIDPROXY({ proxy }) {
return {
message: "Invalid `proxy` option.",
Expand Down
27 changes: 0 additions & 27 deletions lib/verify.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,33 +144,6 @@ export default async function verify(pluginConfig, context, { Octokit }) {
}
}

// Verify if Repository Name wasn't changed
if (
owner &&
repo &&
githubToken &&
!errors.find(({ code }) => code === "EINVALIDPROXY") &&
!errors.find(({ code }) => code === "EMISSINGREPO")
) {
const octokit = new Octokit(
toOctokitOptions({
githubToken,
githubUrl,
githubApiPathPrefix,
githubApiUrl,
proxy,
}),
);

const {
status,
data: { clone_url },
} = await octokit.request("GET /repos/{owner}/{repo}", { owner, repo });
if (status !== 200 || repositoryUrl !== clone_url) {
errors.push(getError("EMISMATCHGITHUBURL"));
}
}

if (!githubToken) {
errors.push(getError("ENOGHTOKEN", { owner, repo }));
}
Expand Down
94 changes: 27 additions & 67 deletions test/integration.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,16 +24,11 @@ test("Verify GitHub auth", async (t) => {
repositoryUrl: `git+https://othertesturl.com/${owner}/${repo}.git`,
};

const fetch = fetchMock.sandbox().get(
`https://api.github.local/repos/${owner}/${repo}`,
{
const fetch = fetchMock
.sandbox()
.getOnce(`https://api.github.local/repos/${owner}/${repo}`, {
permissions: { push: true },
clone_url: `git+https://othertesturl.com/${owner}/${repo}.git`,
},
{
repeat: 2,
},
);
});

await t.notThrowsAsync(
t.context.m.verifyConditions(
Expand All @@ -59,16 +54,11 @@ test("Verify GitHub auth with publish options", async (t) => {
publish: { path: "@semantic-release/github" },
repositoryUrl: `git+https://othertesturl.com/${owner}/${repo}.git`,
};
const fetch = fetchMock.sandbox().get(
`https://api.github.local/repos/${owner}/${repo}`,
{
const fetch = fetchMock
.sandbox()
.getOnce(`https://api.github.local/repos/${owner}/${repo}`, {
permissions: { push: true },
clone_url: `git+https://othertesturl.com/${owner}/${repo}.git`,
},
{
repeat: 2,
},
);
});

await t.notThrowsAsync(
t.context.m.verifyConditions(
Expand Down Expand Up @@ -101,16 +91,11 @@ test("Verify GitHub auth and assets config", async (t) => {
publish: [{ path: "@semantic-release/npm" }],
repositoryUrl: `git+https://othertesturl.com/${owner}/${repo}.git`,
};
const fetch = fetchMock.sandbox().get(
`https://api.github.local/repos/${owner}/${repo}`,
{
const fetch = fetchMock
.sandbox()
.getOnce(`https://api.github.local/repos/${owner}/${repo}`, {
permissions: { push: true },
clone_url: `git+https://othertesturl.com/${owner}/${repo}.git`,
},
{
repeat: 2,
},
);
});

await t.notThrowsAsync(
t.context.m.verifyConditions(
Expand Down Expand Up @@ -211,16 +196,9 @@ test("Publish a release with an array of assets", async (t) => {

const fetch = fetchMock
.sandbox()
.get(
`https://api.github.local/repos/${owner}/${repo}`,
{
permissions: { push: true },
clone_url: `https://github.com/${owner}/${repo}.git`,
},
{
repeat: 2,
},
)
.getOnce(`https://api.github.local/repos/${owner}/${repo}`, {
permissions: { push: true },
})
.postOnce(
`https://api.github.local/repos/${owner}/${repo}/releases`,
{ upload_url: uploadUrl, html_url: releaseUrl, id: releaseId },
Expand Down Expand Up @@ -310,16 +288,9 @@ test("Publish a release with release information in assets", async (t) => {

const fetch = fetchMock
.sandbox()
.get(
`https://api.github.local/repos/${owner}/${repo}`,
{
permissions: { push: true },
clone_url: `https://github.com/${owner}/${repo}.git`,
},
{
repeat: 2,
},
)
.getOnce(`https://api.github.local/repos/${owner}/${repo}`, {
permissions: { push: true },
})
.postOnce(
`https://api.github.local/repos/${owner}/${repo}/releases`,
{ upload_url: uploadUrl, html_url: releaseUrl, id: releaseId },
Expand Down Expand Up @@ -387,16 +358,9 @@ test("Update a release", async (t) => {

const fetch = fetchMock
.sandbox()
.get(
`https://api.github.local/repos/${owner}/${repo}`,
{
permissions: { push: true },
clone_url: `https://github.com/${owner}/${repo}.git`,
},
{
repeat: 2,
},
)
.getOnce(`https://api.github.local/repos/${owner}/${repo}`, {
permissions: { push: true },
})
.getOnce(
`https://api.github.local/repos/${owner}/${repo}/releases/tags/${nextRelease.gitTag}`,
{ id: releaseId },
Expand Down Expand Up @@ -462,10 +426,10 @@ test("Comment and add labels on PR included in the releases", async (t) => {
{
permissions: { push: true },
full_name: `${owner}/${repo}`,
clone_url: `https://github.com/${owner}/${repo}.git`,
},
{
repeat: 3,
// TODO: why do we call the same endpoint twice?
repeat: 2,
},
)
.postOnce("https://api.github.local/graphql", {
Expand Down Expand Up @@ -565,10 +529,9 @@ test("Open a new issue with the list of errors", async (t) => {
{
permissions: { push: true },
full_name: `${owner}/${repo}`,
clone_url: `https://github.com/${owner}/${repo}.git`,
},
{
repeat: 3,
repeat: 2,
},
)
.getOnce(
Expand Down Expand Up @@ -662,10 +625,9 @@ test("Verify, release and notify success", async (t) => {
{
permissions: { push: true },
full_name: `${owner}/${repo}`,
clone_url: `https://github.com/${owner}/${repo}.git`,
},
{
repeat: 3,
repeat: 2,
},
)
.postOnce(
57AE Expand Down Expand Up @@ -823,10 +785,9 @@ test("Verify, update release and notify success", async (t) => {
{
permissions: { push: true },
full_name: `${owner}/${repo}`,
clone_url: `https://github.com/${owner}/${repo}.git`,
},
{
repeat: 3,
repeat: 2,
},
)
.getOnce(
Expand Down Expand Up @@ -956,10 +917,9 @@ test("Verify and notify failure", async (t) => {
{
permissions: { push: true },
full_name: `${owner}/${repo}`,
clone_url: `https://github.com/${owner}/${repo}.git`,
},
{
repeat: 3,
repeat: 2,
},
)
.getOnce(
Expand Down
Loading
0