8000 feat: make success comments filterable by balazsorban44 · Pull Request #360 · semantic-release/github · GitHub
[go: up one dir, main page]
Skip to content

feat: make success comments filterable #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat: make success comments filterable #360

wants to merge 1 commit into from

Conversation

balazsorban44
Copy link

Fixes #359

@balazsorban44 balazsorban44 mentioned this pull request Apr 24, 2021
Merged
3 tasks
@jpsullivan
Copy link
jpsullivan commented May 24, 2021 •
edited by hearts bot
Loading

I know this isn't particularly helpful, but my team has been running into this as well, and would love to see this merged in. If there's anything I can do to assist, please feel free to let me know!

oljp
oljp approved these changes May 25, 2021
View reviewed changes
Copy link
@oljp oljp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. However I do think that documentation should be included for this filter as well.

@balazsorban44
Copy link
Author
balazsorban44 commented May 25, 2021 •
edited by hearts bot
Loading

Of course! I can do, that, if you point me to the right place. 😊

@oljp
8000 Copy link
oljp commented May 25, 2021 •
edited by hearts bot
Loading

I'm not an official maintainer, though if I were to assume I'd go ahead and drop the successFilter into the Options category of the README. https://github.com/semantic-release/github/blob/master/README.md#options, providing a brief description and maybe some example values.

@gr2m
Copy link
Member
gr2m commented May 25, 2021 •
edited by hearts bot
Loading

sorry for the delay with reviewing PRs. We are all pretty swamped right now, but how to find time to review the open PRs and onboard new maintainers soon

@markov00 markov00 mentioned this pull request Nov 3, 2021
Closed
@raffis
Copy link
raffis commented Nov 4, 2022 •
edited by hearts bot
Loading

Any reason this is not merged? Currently I have the problem that if semantic-release with github gets added to an old repo with thousands of merged pr's, you end up with thousands of comments done by semantic-release. I wonder why this was not yet mentioned anywhere.
A filter would help in this case, we could add the released label manually to all merged pr's before introducing semantic-release.
Alternative solution might also the ability to specify a custom github search query.

@raffis raffis mentioned this pull request Nov 4, 2022
Closed
@JonasSchubert JonasSchubert mentioned this pull request Jun 2, 2024
Merged
@babblebey
Copy link
Member
babblebey commented Jul 8, 2024 •
edited by hearts bot
Loading

So we've got a similar feature merged on the semantic-release/gitlab plugin, and more robust at that. It'd be nice if we can replicate the exact same flow here which i believe should succeed this PR. 😉

See semantic-release/gitlab#730

@babblebey babblebey mentioned this pull request Jul 10, 2024
Merged
@github-actions GitHub Actions
Copy link
github-actions bot commented Sep 2, 2024

🎉 This issue has been resolved in version 10.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oljp oljp oljp approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filter PR/Issue that should get a comment on success
6 participants
@balazsorban44 @jpsullivan @oljp @gr2m @raffis @babblebey
0